chrome/browser/printing/print_preview_dialog_controller.cc - Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_preview_dialog_controller.cc

diff --git a/chrome/browser/printing/print_preview_dialog_controller.cc b/chrome/browser/printing/print_preview_dialog_controller.cc

index b9413a0f7cee7f60dc6784884c23ffe8f572b8e8..f5d8a57fb5e465d3d138d801825bcca3da7cfeea 100644

--- a/chrome/browser/printing/print_preview_dialog_controller.cc

+++ b/chrome/browser/printing/print_preview_dialog_controller.cc

@@ -402,7 +402,7 @@ WebContents* PrintPreviewDialogController::CreatePrintPreviewDialog(

// create the popup on the native desktop.

Browser* current_browser = new Browser(

Browser::CreateParams(Browser::TYPE_POPUP, profile,

- chrome::HOST_DESKTOP_TYPE_NATIVE));

+ chrome::GetActiveDesktop()));

if (!current_browser) {

NOTREACHED() << "Failed to create popup browser window";

return NULL;

« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/profiles/avatar_menu_model_browsertest.cc » ('j') | no next file with comments »