Issue 16174002: ash: Change video threshold from 300x225 to 333x250.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16174002: ash: Change video threshold from 300x225 to 333x250. (Closed)

Created:
7 years, 6 months ago by Daniel Erat

Modified:
7 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Change video threshold from 300x225 to 333x250. This increases the minimum dimensions that ash uses when detecting video for the purpose of preventing the screen from being dimmed. It's unlikely that any given set of numbers will be perfect here, but this may help avoid some false positives caused by animated advertisements. BUG=171456 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202817

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ash/wm/video_detector.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/16174002/1

7 years, 6 months ago (2013-05-29 01:51:29 UTC) #3

Message was sent while issue was closed.

Change committed as 202817

Expand Messages | Collapse Messages