Issue 16173008: Reland 203015 "Add ManagedUserTokenFetcher to fetch scoped-down ..."

Issue 16173008: Reland 203015 "Add ManagedUserTokenFetcher to fetch scoped-down ..." (Closed)

Created:
7 years, 6 months ago by Bernhard Bauer

Modified:
7 years, 6 months ago

Reviewers:
Andrew T Wilson (Slow), Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, pam+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland 203015 "Add ManagedUserTokenFetcher to fetch scoped-down tokens" The memory leak in the original version is fixed, by running the message loop at test tear down. TBR=atwilson@chromium.org,rogerta@chromium.org BUG=228833 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203723

Patch Set 1 #

Patch Set 2 : leaks #

Patch Set 3 : fix #

Patch Set 4 : blubb #

Patch Set 5 : sync #

Patch Set 6 : . #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+915 lines, -39 lines)			Patch
M	chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
A	chrome/browser/managed_mode/managed_user_refresh_token_fetcher.h	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A	chrome/browser/managed_mode/managed_user_refresh_token_fetcher.cc	View		1 chunk	+285 lines, -0 lines	0 comments	Download
A	chrome/browser/managed_mode/managed_user_refresh_token_fetcher_unittest.cc	View		1 chunk	+426 lines, -0 lines	0 comments	Download
M	chrome/browser/managed_mode/managed_user_registration_service.h	View		4 chunks	+17 lines, -2 lines	0 comments	Download
M	chrome/browser/managed_mode/managed_user_registration_service.cc	View		4 chunks	+27 lines, -4 lines	0 comments	Download
M	chrome/browser/managed_mode/managed_user_registration_service_factory.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/managed_mode/managed_user_registration_service_unittest.cc	View	1 2 3 4 5	9 chunks	+37 lines, -2 lines	0 comments	Download
M	chrome/browser/signin/android_profile_oauth2_token_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/oauth2_token_service.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/signin/oauth2_token_service.cc	View	1 2 3 4	4 chunks	+3 lines, -15 lines	0 comments	Download
M	chrome/browser/signin/oauth2_token_service_unittest.cc	View	1 2 3 4	2 chunks	+51 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	google_apis/gaia/gaia_oauth_client.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

Drew, Roger: TBR. The original version is in patch set 1.

7 years, 6 months ago (2013-06-03 14:31:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/16173008/17001

7 years, 6 months ago (2013-06-03 14:31:29 UTC) #2

Message was sent while issue was closed.

Change committed as 203723

Expand Messages | Collapse Messages