Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 16168007: Roll gyp r1635:1636. (Closed)

Created:
7 years, 6 months ago by Torne
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Roll gyp r1635:1636. r1636 Android backend: fix references to source top dir. BUG= TBR=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/16168007/1
7 years, 6 months ago (2013-05-29 10:02:45 UTC) #1
Torne
7 years, 6 months ago (2013-05-29 10:03:59 UTC) #2
commit-bot: I haz the power
List of reviewers changed. sbc@chromium.org did a drive-by without LGTM'ing!
7 years, 6 months ago (2013-05-29 12:41:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/16168007/1
7 years, 6 months ago (2013-05-29 12:42:33 UTC) #4
commit-bot: I haz the power
Change committed as 202853
7 years, 6 months ago (2013-05-29 12:42:45 UTC) #5
Sam Clegg
On 2013/05/29 12:41:54, I haz the power (commit-bot) wrote: > List of reviewers changed. mailto:sbc@chromium.org ...
7 years, 6 months ago (2013-05-29 15:34:58 UTC) #6
Torne
7 years, 6 months ago (2013-05-29 15:38:58 UTC) #7
Message was sent while issue was closed.
On 2013/05/29 15:34:58, Sam Clegg wrote:
> On 2013/05/29 12:41:54, I haz the power (commit-bot) wrote:
> > List of reviewers changed. mailto:sbc@chromium.org did a drive-by without
> LGTM'ing!
> 
> What does the commit-bit mean by this exactly?
> 
> I'm pretty sure I was asleep when at the time this message was posted.
> 
> Anyway LGTM...  although there should really be a bug for this, or at least
> BUG=None.

I forgot to actually email you before ticking commit, so it read my message that
changed the list of reviewers as a reason to abort; I think the message is just
confusing and is meant to apply if *you* had added a comment that added you to
the list of reviewers.

And yeah, sorry, next time I'll file a bug for this.

Powered by Google App Engine
This is Rietveld 408576698