Issue 16164003: Field's server type mapping (using Autofill server response) for forms with checkable elements/pass…

Issue 16164003: Field's server type mapping (using Autofill server response) for forms with checkable elements/pass… (Closed)

Created:
7 years, 6 months ago by Raman Kakilate

Modified:
7 years, 6 months ago

Reviewers:
Albert Bodenhamer, Ilya Sherman, Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Field's server type mapping (using Autofill server response) for forms with checkable elements/password fields is off BUG=244290 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202684

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -10 lines)			Patch
M	components/autofill/browser/form_structure.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/autofill/browser/form_structure.cc	View	1	5 chunks	+13 lines, -10 lines	0 comments	Download
M	components/autofill/browser/form_structure_unittest.cc	View		2 chunks	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Raman Kakilate

This is stable release blocker, PTAL ASAP. Thanks,

7 years, 6 months ago (2013-05-28 18:32:24 UTC) #1

Albert Bodenhamer

LGTM You'll need to wait for Evan's review for OWNERS approval. (Ilya is OOO) Thanks ...

7 years, 6 months ago (2013-05-28 18:40:17 UTC) #2

Evan Stade

lgtm https://codereview.chromium.org/16164003/diff/1/components/autofill/browser/form_structure.cc File components/autofill/browser/form_structure.cc (right): https://codereview.chromium.org/16164003/diff/1/components/autofill/browser/form_structure.cc#newcode310 components/autofill/browser/form_structure.cc:310: // Autofill servers. I don't think the comment ...

7 years, 6 months ago (2013-05-28 19:24:07 UTC) #3

Raman Kakilate

https://codereview.chromium.org/16164003/diff/1/components/autofill/browser/form_structure.cc File components/autofill/browser/form_structure.cc (right): https://codereview.chromium.org/16164003/diff/1/components/autofill/browser/form_structure.cc#newcode310 components/autofill/browser/form_structure.cc:310: // Autofill servers. On 2013/05/28 19:24:07, Evan Stade wrote: ...

7 years, 6 months ago (2013-05-28 20:38:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ramankk@chromium.org/16164003/5001

7 years, 6 months ago (2013-05-28 20:39:01 UTC) #5

Message was sent while issue was closed.

Change committed as 202684

Expand Messages | Collapse Messages