Compact the clipstack for kReplace_Op'd geometry

Compact the clipstack for kReplace_Op'd geometry

When adding a clip rect or clip path to the stack with the
kReplace_Op operation, remove all previous elements within the
same save frame (elements with fSaveCount equal to the current
fSaveCount of the stack). This prevents unbounded growth of the
clipstack for long-lived instances that gets reused.

Addresses https://code.google.com/p/skia/issues/detail?id=748

Committed: http://code.google.com/p/skia/source/detail?r=9502

[robertphillips, 2013-06-10 17:10:33]

lgtm + 2 nits

https://codereview.chromium.org/16160020/diff/1/src/core/SkClipStack.cpp
File src/core/SkClipStack.cpp (right):

https://codereview.chromium.org/16160020/diff/1/src/core/SkClipStack.cpp#newc...
src/core/SkClipStack.cpp:534: 
if (NULL != element) {

https://codereview.chromium.org/16160020/diff/1/src/core/SkClipStack.cpp#newc...
src/core/SkClipStack.cpp:582: Element* element = (Element*)fDeque.back();
if (NULL != element) {

[fs, 2013-06-11 07:13:43]

On 2013/06/11 07:06:29, fs wrote:

@robertphillips: Could you help getting this committed when it's fully approved?

[commit-bot: I haz the power, 2013-06-11 10:53:15]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/fs@opera.com/16160020/3002

[commit-bot: I haz the power, 2013-06-11 11:01:50]

Change committed as 9502