Issue 16160015: Update base/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16160015: Update base/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi

Modified:
7 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, gavinp+memory_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update base/ to use scoped_refptr<T>::get() rather than implicit "operator T*" Linux fixes BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203483

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -41 lines)			Patch
M	base/callback_internal.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/files/file_util_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/memory/weak_ptr.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/memory/weak_ptr.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	base/message_loop_unittest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	base/message_pump_libevent_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/observer_list_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/prefs/json_pref_store_unittest.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	base/prefs/pref_member.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	base/prefs/pref_member.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/prefs/pref_value_store.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/prefs/pref_value_store_unittest.cc	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	base/prefs/testing_pref_service.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	base/synchronization/waitable_event_watcher_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16160015/1

7 years, 6 months ago (2013-05-31 17:01:12 UTC) #2

Message was sent while issue was closed.

Change committed as 203483