Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3524)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 16160005: cc: Ignore offscreen tiles for activation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/test/fake_picture_layer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index 0695ba1c28c4ce191ca11a818a616cd87576d421..499574bdd26f5805ec3556eeed660650b6388643 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -825,6 +825,71 @@ TEST_F(PictureLayerImplTest, MarkRequiredNullTiles) {
// It should be safe to call this (and MarkVisibleResourcesAsRequired)
// on a layer with no recordings.
host_impl_.pending_tree()->UpdateDrawProperties();
+ pending_layer_->MarkVisibleResourcesAsRequired();
+}
+
+TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
+ gfx::Size tile_size(100, 100);
+ gfx::Size layer_bounds(200, 100);
+
+ scoped_refptr<FakePicturePileImpl> pending_pile =
+ FakePicturePileImpl::CreateFilledPile(tile_size, layer_bounds);
+ SetupPendingTree(pending_pile);
+
+ pending_layer_->set_fixed_tile_size(tile_size);
+ ASSERT_TRUE(pending_layer_->CanHaveTilings());
+ PictureLayerTiling* tiling = pending_layer_->AddTiling(1.f);
+ host_impl_.pending_tree()->UpdateDrawProperties();
+ EXPECT_EQ(tiling->resolution(), HIGH_RESOLUTION);
+
+ // Fake set priorities.
+ int tile_count = 0;
+ for (PictureLayerTiling::CoverageIterator iter(
+ tiling,
+ pending_layer_->contents_scale_x(),
+ gfx::Rect(pending_layer_->visible_content_rect()));
+ iter;
+ ++iter) {
+ if (!*iter)
+ continue;
+ Tile* tile = *iter;
+ TilePriority priority;
+ priority.resolution = HIGH_RESOLUTION;
+ if (++tile_count % 2) {
+ priority.time_to_visible_in_seconds = 0.f;
+ priority.distance_to_visible_in_pixels = 0.f;
+ } else {
+ priority.time_to_visible_in_seconds = 1.f;
+ priority.distance_to_visible_in_pixels = 1.f;
+ }
+ tile->SetPriority(PENDING_TREE, priority);
+ }
+
+ pending_layer_->MarkVisibleResourcesAsRequired();
+
+ int num_visible = 0;
+ int num_offscreen = 0;
+
+ for (PictureLayerTiling::CoverageIterator iter(
+ tiling,
+ pending_layer_->contents_scale_x(),
+ gfx::Rect(pending_layer_->visible_content_rect()));
+ iter;
+ ++iter) {
+ if (!*iter)
+ continue;
+ const Tile* tile = *iter;
+ if (tile->priority(PENDING_TREE).distance_to_visible_in_pixels == 0.f) {
+ EXPECT_TRUE(tile->required_for_activation());
+ num_visible++;
+ } else {
+ EXPECT_FALSE(tile->required_for_activation());
+ num_offscreen++;
+ }
+ }
+
+ EXPECT_GT(num_visible, 0);
+ EXPECT_GT(num_offscreen, 0);
}
} // namespace
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/test/fake_picture_layer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698