Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 16159004: Hookup driver_bug_workarounds with gl_tests properly. (Closed)

Created:
7 years, 6 months ago by Zhenyao Mo
Modified:
7 years, 6 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Hookup driver_bug_workarounds with gl_tests properly. Get rid of the code duplication of driver_bug_workarounds, i.e., get rid of the hardwired workarounds. Then apply the workarounds from json file to gl_tests. BUG= TEST=gl_tests,gpu_unittests R=gman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -89 lines) Patch
M gpu/command_buffer/service/feature_info.cc View 6 chunks +3 lines, -83 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/tests/gl_tests_main.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_util.h View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/config/gpu_util.cc View 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Gregg, please take a look.
7 years, 6 months ago (2013-05-28 18:05:40 UTC) #1
greggman
lgtm
7 years, 6 months ago (2013-05-28 18:16:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/16159004/1
7 years, 6 months ago (2013-05-28 18:51:14 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 23:14:45 UTC) #4
Message was sent while issue was closed.
Change committed as 202682

Powered by Google App Engine
This is Rietveld 408576698