Issue 16159002: Remove reference to deprecated notification type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16159002: Remove reference to deprecated notification type (Closed)

Created:
7 years, 6 months ago by Pete Williamson

Modified:
7 years, 6 months ago

Reviewers:
miket_OOO, Andrew T Wilson (Slow)

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove reference to deprecated notification type NOTIFICATION_TYPE_SIMPLE has been removed from rich notifications. So, we should no longer rely on that constant. While I am at it, I also cleaned up a comment, and removed a reference to a unit test that we ended up not using. BUG=243959 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203871

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -4 lines)			Patch
M	chrome/browser/background/background_mode_manager.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/push_messaging/push_messaging_api.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/notifications/sync_notifier/synced_notification.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Pete Williamson

atwilson@ please review the change to background_mode_manager.h miket@ Please review the comment change to push_messaging_api.h ...

7 years, 6 months ago (2013-05-28 16:41:21 UTC) #1

Andrew T Wilson (Slow)

On 2013/05/28 16:41:21, Pete Williamson wrote: > atwilson@ please review the change to background_mode_manager.h lgtm

7 years, 6 months ago (2013-05-29 08:33:49 UTC) #2

miket_OOO

lgtm On Wed, May 29, 2013 at 1:33 AM, <atwilson@chromium.org> wrote: > On 2013/05/28 16:41:21, ...

7 years, 6 months ago (2013-06-03 20:19:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/16159002/1

7 years, 6 months ago (2013-06-03 20:20:46 UTC) #4

Message was sent while issue was closed.

Change committed as 203871

Expand Messages | Collapse Messages