webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc - Issue 16155009: Update webkit/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc

Issue 16155009: Update webkit/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc ('k') | webkit/browser/fileapi/file_system_quota_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc

diff --git a/webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc b/webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc

index 68a7132c86a11ebbf15fd541e51744b8e29e9db0..31f91aed4a269dadc5069dd438b12eb2cf6a6c88 100644

--- a/webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc

+++ b/webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc

@@ -43,7 +43,7 @@ void ReadFromReader(FileSystemFileStreamReader* reader,

while (total_bytes_read < size) {

scoped_refptr<net::IOBufferWithSize> buf(

new net::IOBufferWithSize(size - total_bytes_read));

- int rv = reader->Read(buf, buf->size(), callback.callback());

+ int rv = reader->Read(buf.get(), buf->size(), callback.callback());

if (rv == net::ERR_IO_PENDING)

rv = callback.WaitForResult();

if (rv < 0)

@@ -89,7 +89,7 @@ class FileSystemFileStreamReaderTest : public testing::Test {

const std::string& file_name,

int64 initial_offset,

const base::Time& expected_modification_time) {

- return new FileSystemFileStreamReader(file_system_context_,

+ return new FileSystemFileStreamReader(file_system_context_.get(),

GetFileSystemURL(file_name),

initial_offset,

expected_modification_time);

@@ -107,7 +107,7 @@ class FileSystemFileStreamReaderTest : public testing::Test {

sandbox_provider()->GetFileUtil(kFileSystemTypeTemporary);

FileSystemURL url = GetFileSystemURL(file_name);

- FileSystemOperationContext context(file_system_context_);

+ FileSystemOperationContext context(file_system_context_.get());

context.set_allowed_bytes_growth(1024);

base::PlatformFile handle = base::kInvalidPlatformFileValue;

@@ -271,7 +271,7 @@ TEST_F(FileSystemFileStreamReaderTest, DeleteWithUnfinishedRead) {

net::TestCompletionCallback callback;

scoped_refptr<net::IOBufferWithSize> buf(

new net::IOBufferWithSize(kTestDataSize));

- int rv = reader->Read(buf, buf->size(), base::Bind(&NeverCalled));

+ int rv = reader->Read(buf.get(), buf->size(), base::Bind(&NeverCalled));

ASSERT_TRUE(rv == net::ERR_IO_PENDING || rv >= 0);

// Delete immediately.