Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: webkit/appcache/view_appcache_internals_job.cc

Issue 16155009: Update webkit/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/mock_appcache_storage_unittest.cc ('k') | webkit/browser/blob/blob_storage_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/view_appcache_internals_job.cc
diff --git a/webkit/appcache/view_appcache_internals_job.cc b/webkit/appcache/view_appcache_internals_job.cc
index 1cff8e13dc0f1c3bebca15541743c46e249a828b..9c207d0185a9d96f8e4c922c2d1706c663115518 100644
--- a/webkit/appcache/view_appcache_internals_job.cc
+++ b/webkit/appcache/view_appcache_internals_job.cc
@@ -335,8 +335,9 @@ class MainPageJob : public BaseInternalsJob {
DCHECK(request_);
info_collection_ = new AppCacheInfoCollection;
appcache_service_->GetAllAppCacheInfo(
- info_collection_, base::Bind(&MainPageJob::OnGotInfoComplete,
- weak_factory_.GetWeakPtr()));
+ info_collection_.get(),
+ base::Bind(&MainPageJob::OnGotInfoComplete,
+ weak_factory_.GetWeakPtr()));
}
// Produces a page containing the listing
@@ -349,7 +350,7 @@ class MainPageJob : public BaseInternalsJob {
out->clear();
EmitPageStart(out);
- if (!info_collection_) {
+ if (!info_collection_.get()) {
out->append(kErrorMessage);
} else if (info_collection_->infos_by_origin.empty()) {
out->append(kEmptyAppCachesMessage);
@@ -548,15 +549,18 @@ class ViewEntryJob : public BaseInternalsJob,
EmitPageStart(out);
EmitAnchor(entry_url_.spec(), entry_url_.spec(), out);
out->append("<br/>\n");
- if (response_info_) {
+ if (response_info_.get()) {
if (response_info_->http_response_info())
- EmitResponseHeaders(response_info_->http_response_info()->headers, out);
+ EmitResponseHeaders(response_info_->http_response_info()->headers.get(),
+ out);
else
out->append("Failed to read response headers.<br>");
- if (response_data_) {
- EmitHexDump(response_data_->data(), amount_read_,
- response_info_->response_data_size(), out);
+ if (response_data_.get()) {
+ EmitHexDump(response_data_->data(),
+ amount_read_,
+ response_info_->response_data_size(),
+ out);
} else {
out->append("Failed to read response data.<br>");
}
@@ -589,7 +593,8 @@ class ViewEntryJob : public BaseInternalsJob,
reader_.reset(appcache_service_->storage()->CreateResponseReader(
manifest_url_, group_id_, response_id_));
reader_->ReadData(
- response_data_, amount_to_read,
+ response_data_.get(),
+ amount_to_read,
base::Bind(&ViewEntryJob::OnReadComplete, base::Unretained(this)));
}
« no previous file with comments | « webkit/appcache/mock_appcache_storage_unittest.cc ('k') | webkit/browser/blob/blob_storage_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698