Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: webkit/common/blob/shareable_file_reference_unittest.cc

Issue 16155009: Update webkit/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/common/blob/scoped_file.cc ('k') | webkit/common/gpu/test_context_provider_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/common/blob/shareable_file_reference.h" 5 #include "webkit/common/blob/shareable_file_reference.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/message_loop_proxy.h" 10 #include "base/message_loop_proxy.h"
(...skipping 11 matching lines...) Expand all
22 // Create a file. 22 // Create a file.
23 base::FilePath file; 23 base::FilePath file;
24 file_util::CreateTemporaryFileInDir(temp_dir.path(), &file); 24 file_util::CreateTemporaryFileInDir(temp_dir.path(), &file);
25 EXPECT_TRUE(file_util::PathExists(file)); 25 EXPECT_TRUE(file_util::PathExists(file));
26 26
27 // Create a first reference to that file. 27 // Create a first reference to that file.
28 scoped_refptr<ShareableFileReference> reference1; 28 scoped_refptr<ShareableFileReference> reference1;
29 reference1 = ShareableFileReference::Get(file); 29 reference1 = ShareableFileReference::Get(file);
30 EXPECT_FALSE(reference1.get()); 30 EXPECT_FALSE(reference1.get());
31 reference1 = ShareableFileReference::GetOrCreate( 31 reference1 = ShareableFileReference::GetOrCreate(
32 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy); 32 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get());
33 EXPECT_TRUE(reference1.get()); 33 EXPECT_TRUE(reference1.get());
34 EXPECT_TRUE(file == reference1->path()); 34 EXPECT_TRUE(file == reference1->path());
35 35
36 // Get a second reference to that file. 36 // Get a second reference to that file.
37 scoped_refptr<ShareableFileReference> reference2; 37 scoped_refptr<ShareableFileReference> reference2;
38 reference2 = ShareableFileReference::Get(file); 38 reference2 = ShareableFileReference::Get(file);
39 EXPECT_EQ(reference1.get(), reference2.get()); 39 EXPECT_EQ(reference1.get(), reference2.get());
40 reference2 = ShareableFileReference::GetOrCreate( 40 reference2 = ShareableFileReference::GetOrCreate(
41 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy); 41 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get());
42 EXPECT_EQ(reference1.get(), reference2.get()); 42 EXPECT_EQ(reference1.get(), reference2.get());
43 43
44 // Drop the first reference, the file and reference should still be there. 44 // Drop the first reference, the file and reference should still be there.
45 reference1 = NULL; 45 reference1 = NULL;
46 EXPECT_TRUE(ShareableFileReference::Get(file).get()); 46 EXPECT_TRUE(ShareableFileReference::Get(file).get());
47 base::MessageLoop::current()->RunUntilIdle(); 47 base::MessageLoop::current()->RunUntilIdle();
48 EXPECT_TRUE(file_util::PathExists(file)); 48 EXPECT_TRUE(file_util::PathExists(file));
49 49
50 // Drop the second reference, the file and reference should get deleted. 50 // Drop the second reference, the file and reference should get deleted.
51 reference2 = NULL; 51 reference2 = NULL;
52 EXPECT_FALSE(ShareableFileReference::Get(file).get()); 52 EXPECT_FALSE(ShareableFileReference::Get(file).get());
53 base::MessageLoop::current()->RunUntilIdle(); 53 base::MessageLoop::current()->RunUntilIdle();
54 EXPECT_FALSE(file_util::PathExists(file)); 54 EXPECT_FALSE(file_util::PathExists(file));
55 55
56 // TODO(michaeln): add a test for files that aren't deletable behavior. 56 // TODO(michaeln): add a test for files that aren't deletable behavior.
57 } 57 }
58 58
59 } // namespace webkit_blob 59 } // namespace webkit_blob
OLDNEW
« no previous file with comments | « webkit/common/blob/scoped_file.cc ('k') | webkit/common/gpu/test_context_provider_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698