Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4010)

Unified Diff: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc

Issue 16154031: Un-refcount AutofillWebData and TokenWebData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
index ce020f96c5438e8d0c995135f8ec2803a821d5db..b506b0821974021b291ba28c83db571ca569e951 100644
--- a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
@@ -106,10 +106,10 @@ class FakeWebDataService : public AutofillWebDataService {
return result;
}
- private:
virtual ~FakeWebDataService() {
}
+ private:
void CreateSyncableService() {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
// These services are deleted in DestroySyncableService().
@@ -226,7 +226,7 @@ class SyncAutofillDataTypeControllerTest : public testing::Test {
TEST_F(SyncAutofillDataTypeControllerTest, StartWDSReady) {
FakeWebDataService* web_db =
static_cast<FakeWebDataService*>(
- AutofillWebDataService::FromBrowserContext(&profile_).get());
+ AutofillWebDataService::FromBrowserContext(&profile_));
web_db->LoadDatabase();
autofill_dtc_->LoadModels(
base::Bind(&SyncAutofillDataTypeControllerTest::OnLoadFinished,
@@ -259,7 +259,7 @@ TEST_F(SyncAutofillDataTypeControllerTest, StartWDSNotReady) {
FakeWebDataService* web_db =
static_cast<FakeWebDataService*>(
- AutofillWebDataService::FromBrowserContext(&profile_).get());
+ AutofillWebDataService::FromBrowserContext(&profile_));
web_db->LoadDatabase();
EXPECT_CALL(*change_processor_.get(), Connect(_, _, _, _, _))
@@ -278,13 +278,13 @@ TEST_F(SyncAutofillDataTypeControllerTest, StartWDSNotReady) {
TEST_F(SyncAutofillDataTypeControllerTest, UpdateAutofillCullingSettings) {
FakeWebDataService* web_db =
static_cast<FakeWebDataService*>(
- AutofillWebDataService::FromBrowserContext(&profile_).get());
+ AutofillWebDataService::FromBrowserContext(&profile_));
// Set up the experiments state.
- ProfileSyncService* sync = ProfileSyncServiceFactory::GetForProfile(
- &profile_);
syncer::Experiments experiments;
experiments.autofill_culling = true;
+ ProfileSyncService* sync = ProfileSyncServiceFactory::GetForProfile(
+ &profile_);
sync->OnExperimentsChanged(experiments);
web_db->LoadDatabase();

Powered by Google App Engine
This is Rietveld 408576698