Android WebView: add rules for jarjar.

Android WebView: add rules for jarjar.

Add jarjar rules that will rename all the Java classes defined in
Chromium code to be under a private package name when building the
WebView. This is only used when building inside the Android tree, so
does not affect upstream testing.

BUG=
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203926

[benm (inactive), 2013-06-04 10:15:13]

lgtm

[commit-bot: I haz the power, 2013-06-04 10:31:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/16154019/1

[commit-bot: I haz the power, 2013-06-04 11:11:25]

Change committed as 203926

[joth, 2013-06-04 17:11:45]

side-question - how do we validate this / catch in future if new packages
are added that don't match any of these rules?



On 4 June 2013 02:57, <torne@chromium.org> wrote:

> Reviewers: benm,
>
> Description:
> Android WebView: add rules for jarjar.
>
> Add jarjar rules that will rename all the Java classes defined in
> Chromium code to be under a private package name when building the
> WebView. This is only used when building inside the Android tree, so
> does not affect upstream testing.
>
> BUG=
>
> Please review this at
https://codereview.chromium.**org/16154019/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M android_webview/build/jarjar-**rules.txt
>
>
> Index: android_webview/build/jarjar-**rules.txt
> diff --git a/android_webview/build/**jarjar-rules.txt
> b/android_webview/build/**jarjar-rules.txt
> index e69de29bb2d1d6434b8b29ae775ad8**c2e48c5391..**
> dcd12a52506cdf8d85c67a39809c4d**a0c91e1ffd 100644
> --- a/android_webview/build/**jarjar-rules.txt
> +++ b/android_webview/build/**jarjar-rules.txt
> @@ -0,0 +1,4 @@
> +rule org.chromium.** com.android.internal.**webviewchromium.@1
> +rule com.google.common.** com.android.internal.**webviewchromium.guava.@1
> +rule com.googlecode.eyesfree.** com.android.internal.**
> webviewchromium.eyesfree.@1
> +rule javax.annotation.** com.android.internal.**webviewchromium.jsr305.@1
>
>
>

[benm (inactive), 2013-06-04 17:35:41]

As this is built by the Android.mk we've got checked in upstream, if a new
java dependency was added upstream we'd get a build break until we add it
to that file, at which time we'd need to update the jarjar rules to rename
it as well (I think).


On 4 June 2013 18:11, Jonathan Dixon <joth@chromium.org> wrote:

> side-question - how do we validate this / catch in future if new packages
> are added that don't match any of these rules?
>
>
>
> On 4 June 2013 02:57, <torne@chromium.org> wrote:
>
>> Reviewers: benm,
>>
>> Description:
>> Android WebView: add rules for jarjar.
>>
>> Add jarjar rules that will rename all the Java classes defined in
>> Chromium code to be under a private package name when building the
>> WebView. This is only used when building inside the Android tree, so
>> does not affect upstream testing.
>>
>> BUG=
>>
>> Please review this at
https://codereview.chromium.**org/16154019/<https://codereview.chromium.org/1...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>>
>> Affected files:
>>   M android_webview/build/jarjar-**rules.txt
>>
>>
>> Index: android_webview/build/jarjar-**rules.txt
>> diff --git a/android_webview/build/**jarjar-rules.txt
>> b/android_webview/build/**jarjar-rules.txt
>> index e69de29bb2d1d6434b8b29ae775ad8**c2e48c5391..**
>> dcd12a52506cdf8d85c67a39809c4d**a0c91e1ffd 100644
>> --- a/android_webview/build/**jarjar-rules.txt
>> +++ b/android_webview/build/**jarjar-rules.txt
>> @@ -0,0 +1,4 @@
>> +rule org.chromium.** com.android.internal.**webviewchromium.@1
>> +rule com.google.common.** com.android.internal.**
>> webviewchromium.guava.@1
>> +rule com.googlecode.eyesfree.** com.android.internal.**
>> webviewchromium.eyesfree.@1
>> +rule javax.annotation.** com.android.internal.**
>> webviewchromium.jsr305.@1
>>
>>
>>
>