Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 16152005: Change to 72 column reference in git cl upload message (Closed)

Created:
7 years, 6 months ago by alancutter (OOO until 2018)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Change to 72 column reference in git cl upload message 76 columns is fine for most patches but reverts will eat another 4 spaces in indentation. For the sake of revert clarity this reference line is reduced to 72 columns. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=203530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M git_cl.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/git_cl_test.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alancutter (OOO until 2018)
This is an update to https://codereview.chromium.org/15670012/ after feedback.
7 years, 6 months ago (2013-05-31 05:56:56 UTC) #1
Noel Gordon
LGTM thx.
7 years, 6 months ago (2013-05-31 05:57:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/16152005/1
7 years, 6 months ago (2013-06-01 00:22:33 UTC) #3
commit-bot: I haz the power
Presubmit check for 16152005-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 6 months ago (2013-06-01 00:24:14 UTC) #4
M-A Ruel
lgtm
7 years, 6 months ago (2013-06-01 00:32:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/16152005/1
7 years, 6 months ago (2013-06-01 00:32:56 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-01 00:34:38 UTC) #7
Message was sent while issue was closed.
Change committed as 203530

Powered by Google App Engine
This is Rietveld 408576698