Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 16147015: Fix grammar in recurring macro comment (Closed)

Created:
7 years, 6 months ago by janx
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, akalin, Raghu Simha, mmenke, haitaol1, erikwright+watch_chromium.org, tim (not reviewing)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix grammar in recurring macro comment Trivial patch changing "generate enum" to "generate enum values" in comments justifying the lack of include guards in xmacro value lists. NOTRY=true TBR=yfriedman,atwilson,gavinp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206405

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M base/android/activity_state_list.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_model_type_selection_android.h View 1 chunk +1 line, -1 line 0 comments Download
M net/android/cert_verify_result_android_list.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util_certificate_type_list.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_error_list.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
janx
This commit has been copy/pasted across the code base, and it is not grammatically correct: ...
7 years, 6 months ago (2013-06-07 12:58:31 UTC) #1
Peter Beverloo
lgtm, thanks! Feel free to commit with "TBR=yfriedman, atwilson, gavinp", which should cover all OWNERS ...
7 years, 6 months ago (2013-06-13 16:32:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/janx@chromium.org/16147015/5001
7 years, 6 months ago (2013-06-13 16:43:39 UTC) #3
gavinp
lgtm
7 years, 6 months ago (2013-06-13 16:44:53 UTC) #4
janx
Thanks Peter and Gavin! FYI the fix was requested by Avi.
7 years, 6 months ago (2013-06-13 16:45:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=49746
7 years, 6 months ago (2013-06-13 17:46:38 UTC) #6
Andrew T Wilson (Slow)
sync lgtm
7 years, 6 months ago (2013-06-14 09:31:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/janx@chromium.org/16147015/5001
7 years, 6 months ago (2013-06-14 09:45:15 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=163388
7 years, 6 months ago (2013-06-14 11:50:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/janx@chromium.org/16147015/5001
7 years, 6 months ago (2013-06-14 13:00:09 UTC) #10
commit-bot: I haz the power
Change committed as 206405
7 years, 6 months ago (2013-06-14 13:00:24 UTC) #11
janx
Commited with NOTRY because the change is trivial and the commit queue was being uncooperative.
7 years, 6 months ago (2013-06-14 13:07:02 UTC) #12
Yaron
7 years, 6 months ago (2013-06-18 16:26:56 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698