Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 16142004: device: Gyp organization part 2. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

device: Gyp organization part 2. This moves media_transfer_protocol targets into: device/media_transfer_protocol/media_transfer_protocol.gyp So it's consistent with what we have done with bluetooth and usb directories/targets. R=bryeung@chromium.org,miket@chromium.org,thestig@chromium.org TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204040

Patch Set 1 #

Total comments: 2

Patch Set 2 : add it back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -54 lines) Patch
M chrome/chrome_browser.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M device/device.gyp View 1 chunk +0 lines, -49 lines 0 comments Download
A device/media_transfer_protocol/media_transfer_protocol.gyp View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/mtpd/mtpd.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
Guys, as discussed in email. Brya, Mike device/ overall. Lei chrome/ and media_transfer_protocol OWNER :)
7 years, 6 months ago (2013-06-04 00:25:48 UTC) #1
Lei Zhang
https://codereview.chromium.org/16142004/diff/1/build/all.gyp File build/all.gyp (left): https://codereview.chromium.org/16142004/diff/1/build/all.gyp#oldcode39 build/all.gyp:39: '../device/device.gyp:*', Don't we still want device_unittests to build for ...
7 years, 6 months ago (2013-06-04 00:44:41 UTC) #2
tfarina
https://codereview.chromium.org/16142004/diff/1/build/all.gyp File build/all.gyp (left): https://codereview.chromium.org/16142004/diff/1/build/all.gyp#oldcode39 build/all.gyp:39: '../device/device.gyp:*', On 2013/06/04 00:44:41, Lei Zhang wrote: > Don't ...
7 years, 6 months ago (2013-06-04 00:46:45 UTC) #3
Lei Zhang
lgtm
7 years, 6 months ago (2013-06-04 00:50:05 UTC) #4
bryeung
lgtm
7 years, 6 months ago (2013-06-04 14:49:50 UTC) #5
miket_OOO
lgtm
7 years, 6 months ago (2013-06-04 16:02:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16142004/4001
7 years, 6 months ago (2013-06-04 19:30:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6707
7 years, 6 months ago (2013-06-04 19:38:58 UTC) #8
tfarina
TBRing Lei for third_party/mtpd.
7 years, 6 months ago (2013-06-04 19:49:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16142004/4001
7 years, 6 months ago (2013-06-04 19:50:00 UTC) #10
Lei Zhang
On 2013/06/04 19:49:34, tfarina wrote: > TBRing Lei for third_party/mtpd. I already gave an lg, ...
7 years, 6 months ago (2013-06-04 20:25:09 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 21:01:05 UTC) #12
Message was sent while issue was closed.
Change committed as 204040

Powered by Google App Engine
This is Rietveld 408576698