Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: ash/display/display_manager_unittest.cc

Issue 161413002: Revert of Read compositor VSync information from platform, when possible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/display/display_manager.cc ('k') | ash/display/resolution_notification_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_manager_unittest.cc
diff --git a/ash/display/display_manager_unittest.cc b/ash/display/display_manager_unittest.cc
index 5b43b1b467dc3916efb75ccf00738bbd5525d9ca..9300ccc8ae60fc6cf52bd6d210328a852c747a48 100644
--- a/ash/display/display_manager_unittest.cc
+++ b/ash/display/display_manager_unittest.cc
@@ -719,60 +719,49 @@
int display_id = 1000;
DisplayInfo native_display_info =
CreateDisplayInfo(display_id, gfx::Rect(0, 0, 1000, 500));
- std::vector<DisplayMode> display_modes;
- display_modes.push_back(
- DisplayMode(gfx::Size(1000, 500), 58.0f, false, true));
- display_modes.push_back(
- DisplayMode(gfx::Size(800, 300), 59.0f, false, false));
- display_modes.push_back(
- DisplayMode(gfx::Size(400, 500), 60.0f, false, false));
-
- native_display_info.set_display_modes(display_modes);
+ std::vector<Resolution> resolutions;
+ resolutions.push_back(Resolution(gfx::Size(1000, 500), false));
+ resolutions.push_back(Resolution(gfx::Size(800, 300), false));
+ resolutions.push_back(Resolution(gfx::Size(400, 500), false));
+
+ native_display_info.set_resolutions(resolutions);
std::vector<DisplayInfo> display_info_list;
display_info_list.push_back(native_display_info);
display_manager()->OnNativeDisplaysChanged(display_info_list);
- DisplayMode mode;
- EXPECT_FALSE(
- display_manager()->GetSelectedModeForDisplayId(display_id, &mode));
+ gfx::Size selected;
+ EXPECT_FALSE(display_manager()->GetSelectedResolutionForDisplayId(
+ display_id, &selected));
// Unsupported resolution.
display_manager()->SetDisplayResolution(display_id, gfx::Size(800, 4000));
- EXPECT_FALSE(
- display_manager()->GetSelectedModeForDisplayId(display_id, &mode));
+ EXPECT_FALSE(display_manager()->GetSelectedResolutionForDisplayId(
+ display_id, &selected));
// Supported resolution.
display_manager()->SetDisplayResolution(display_id, gfx::Size(800, 300));
- EXPECT_TRUE(
- display_manager()->GetSelectedModeForDisplayId(display_id, &mode));
- EXPECT_EQ("800x300", mode.size.ToString());
- EXPECT_EQ(59.0f, mode.refresh_rate);
- EXPECT_FALSE(mode.native);
+ EXPECT_TRUE(display_manager()->GetSelectedResolutionForDisplayId(
+ display_id, &selected));
+ EXPECT_EQ("800x300", selected.ToString());
// Best resolution.
display_manager()->SetDisplayResolution(display_id, gfx::Size(1000, 500));
- EXPECT_TRUE(
- display_manager()->GetSelectedModeForDisplayId(display_id, &mode));
- EXPECT_EQ("1000x500", mode.size.ToString());
- EXPECT_EQ(58.0f, mode.refresh_rate);
- EXPECT_TRUE(mode.native);
+ EXPECT_FALSE(display_manager()->GetSelectedResolutionForDisplayId(
+ display_id, &selected));
}
TEST_F(DisplayManagerTest, ResolutionFallback) {
int display_id = 1000;
DisplayInfo native_display_info =
CreateDisplayInfo(display_id, gfx::Rect(0, 0, 1000, 500));
- std::vector<DisplayMode> display_modes;
- display_modes.push_back(
- DisplayMode(gfx::Size(1000, 500), 58.0f, false, true));
- display_modes.push_back(
- DisplayMode(gfx::Size(800, 300), 59.0f, false, false));
- display_modes.push_back(
- DisplayMode(gfx::Size(400, 500), 60.0f, false, false));
-
- std::vector<DisplayMode> copy = display_modes;
- native_display_info.set_display_modes(copy);
+ std::vector<Resolution> resolutions;
+ resolutions.push_back(Resolution(gfx::Size(1000, 500), false));
+ resolutions.push_back(Resolution(gfx::Size(800, 300), false));
+ resolutions.push_back(Resolution(gfx::Size(400, 500), false));
+
+ std::vector<Resolution> copy = resolutions;
+ native_display_info.set_resolutions(copy);
std::vector<DisplayInfo> display_info_list;
display_info_list.push_back(native_display_info);
@@ -781,36 +770,31 @@
display_manager()->SetDisplayResolution(display_id, gfx::Size(800, 300));
DisplayInfo new_native_display_info =
CreateDisplayInfo(display_id, gfx::Rect(0, 0, 400, 500));
- copy = display_modes;
- new_native_display_info.set_display_modes(copy);
+ copy = resolutions;
+ new_native_display_info.set_resolutions(copy);
std::vector<DisplayInfo> new_display_info_list;
new_display_info_list.push_back(new_native_display_info);
display_manager()->OnNativeDisplaysChanged(new_display_info_list);
- DisplayMode mode;
- EXPECT_TRUE(
- display_manager()->GetSelectedModeForDisplayId(display_id, &mode));
- EXPECT_EQ("400x500", mode.size.ToString());
- EXPECT_EQ(60.0f, mode.refresh_rate);
- EXPECT_FALSE(mode.native);
+ gfx::Size selected;
+ EXPECT_TRUE(display_manager()->GetSelectedResolutionForDisplayId(
+ display_id, &selected));
+ EXPECT_EQ("400x500", selected.ToString());
}
{
- // Best resolution should find itself on the resolutions list.
+ // Best resolution should not be set.
display_manager()->SetDisplayResolution(display_id, gfx::Size(800, 300));
DisplayInfo new_native_display_info =
CreateDisplayInfo(display_id, gfx::Rect(0, 0, 1000, 500));
- std::vector<DisplayMode> copy = display_modes;
- new_native_display_info.set_display_modes(copy);
+ std::vector<Resolution> copy = resolutions;
+ new_native_display_info.set_resolutions(copy);
std::vector<DisplayInfo> new_display_info_list;
new_display_info_list.push_back(new_native_display_info);
display_manager()->OnNativeDisplaysChanged(new_display_info_list);
- DisplayMode mode;
- EXPECT_TRUE(
- display_manager()->GetSelectedModeForDisplayId(display_id, &mode));
- EXPECT_EQ("1000x500", mode.size.ToString());
- EXPECT_EQ(58.0f, mode.refresh_rate);
- EXPECT_TRUE(mode.native);
+ gfx::Size selected;
+ EXPECT_FALSE(display_manager()->GetSelectedResolutionForDisplayId(
+ display_id, &selected));
}
}
« no previous file with comments | « ash/display/display_manager.cc ('k') | ash/display/resolution_notification_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698