Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 161413002: Revert of Read compositor VSync information from platform, when possible (Closed)

Created:
6 years, 10 months ago by sheu
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, joi+watch-content_chromium.org, sadrul, nkostylev+watch_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, stevenjb+watch_chromium.org, danakj+watch_chromium.org, ben+ash_chromium.org, brianderson, nduca, Sami
Visibility:
Public.

Description

Revert of Read compositor VSync information from platform, when possible (https://chromiumcodereview.appspot.com/138903025/) Reason for revert: Reverting due to Windows crashes. See: http://crbug.com/343199 Original issue's description: > Read compositor VSync information from platform, when possible > > The current query of VSync information through the GL context can be unreliable > on platforms that can dynamically disable vblanks, or multi-monitor setups. > Preferentially query the VSync information through the platform windowing > system (presently: XRandR on CrOS) when possible. > > BUG=328953 > TEST=local build, run on CrOS snow > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250250 TBR=oshima@chromium.org,piman@chromium.org,brianderson@chromium.org,sky@chromium.org,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=328953 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -607 lines) Patch
M ash/display/display_change_observer_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 4 chunks +33 lines, -36 lines 0 comments Download
M ash/display/display_change_observer_chromeos_unittest.cc View 2 chunks +18 lines, -24 lines 0 comments Download
M ash/display/display_controller.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M ash/display/display_info.h View 5 chunks +19 lines, -24 lines 0 comments Download
M ash/display/display_info.cc View 5 chunks +21 lines, -52 lines 0 comments Download
M ash/display/display_info_unittest.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M ash/display/display_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/display/display_manager.cc View 5 chunks +40 lines, -34 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 2 chunks +35 lines, -51 lines 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 12 chunks +57 lines, -70 lines 0 comments Download
M ash/wm/window_animations.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/output/output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/output_surface.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 6 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 6 chunks +17 lines, -23 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 4 chunks +13 lines, -11 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.h View 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/desktop_capture_device_aura.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 5 chunks +5 lines, -8 lines 0 comments Download
M ui/compositor/compositor.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/compositor_observer.h View 1 chunk +5 lines, -0 lines 0 comments Download
D ui/compositor/compositor_vsync_manager.h View 1 chunk +0 lines, -71 lines 0 comments Download
D ui/compositor/compositor_vsync_manager.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.cc View 1 chunk +10 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sheu
Created Revert of Read compositor VSync information from platform, when possible
6 years, 10 months ago (2014-02-12 21:44:25 UTC) #1
oshima
lgtm you don't need review if it's simple revert (in case you were not sure).
6 years, 10 months ago (2014-02-12 21:48:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/161413002/1
6 years, 10 months ago (2014-02-12 21:49:07 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 21:51:59 UTC) #4
Message was sent while issue was closed.
Change committed as 250798

Powered by Google App Engine
This is Rietveld 408576698