Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 16140026: fix a problem that download dangerous files in a blank page can fail with authentication (Closed)

Created:
7 years, 6 months ago by qinmin
Modified:
7 years, 6 months ago
Reviewers:
Yaron, nilesh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

fix a problem that download dangerous files in a blank page can fail with authentication With the chrome download path, when onDownloadStarted() is called, we close the tab if it is blank. The close call come too early as onDangerousDownload() has not been called yet. This CL sends the filename and mimeType to java side to check if we can close the tab or not. Also, if the tab is closed after user validates the dangerous item, the onDownloadComplete() should send a message to the app, rather than tab. BUG=244052 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204030

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove public keyword from interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -38 lines) Patch
M content/browser/android/download_controller_android_impl.cc View 2 chunks +13 lines, -15 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java View 1 chunk +3 lines, -12 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/DownloadController.java View 1 4 chunks +37 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qinmin
PTAL
7 years, 6 months ago (2013-06-04 00:17:02 UTC) #1
nilesh
LGTM with nit https://codereview.chromium.org/16140026/diff/1/content/public/android/java/src/org/chromium/content/browser/DownloadController.java File content/public/android/java/src/org/chromium/content/browser/DownloadController.java (right): https://codereview.chromium.org/16140026/diff/1/content/public/android/java/src/org/chromium/content/browser/DownloadController.java#newcode36 content/public/android/java/src/org/chromium/content/browser/DownloadController.java:36: public void onDownloadCompleted(Context context, String url, ...
7 years, 6 months ago (2013-06-04 00:54:00 UTC) #2
qinmin
https://codereview.chromium.org/16140026/diff/1/content/public/android/java/src/org/chromium/content/browser/DownloadController.java File content/public/android/java/src/org/chromium/content/browser/DownloadController.java (right): https://codereview.chromium.org/16140026/diff/1/content/public/android/java/src/org/chromium/content/browser/DownloadController.java#newcode36 content/public/android/java/src/org/chromium/content/browser/DownloadController.java:36: public void onDownloadCompleted(Context context, String url, String mimetype, String ...
7 years, 6 months ago (2013-06-04 02:26:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/16140026/5001
7 years, 6 months ago (2013-06-04 14:23:03 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 20:35:53 UTC) #5
Message was sent while issue was closed.
Change committed as 204030

Powered by Google App Engine
This is Rietveld 408576698