Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 16140020: Delete NetworkingContext and its subclasses. (Closed)

Created:
7 years, 6 months ago by Nate Chapin
Modified:
7 years, 6 months ago
Reviewers:
pdr., abarth-chromium
CC:
blink-reviews, jeez, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Delete NetworkingContext and its subclasses. They are only used to access CookieJar, which can sanely be accessed directly. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151710

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -275 lines) Patch
M Source/WebKit/chromium/WebKit.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
D Source/WebKit/chromium/src/FrameNetworkingContextImpl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/WebKit/chromium/src/FrameNetworkingContextImpl.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
M Source/core/loader/CookieJar.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 6 chunks +1 line, -13 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 2 chunks +5 lines, -1 line 0 comments Download
D Source/core/loader/FrameNetworkingContext.h View 1 chunk +0 lines, -58 lines 0 comments Download
M Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/network/NetworkingContext.h View 1 chunk +0 lines, -45 lines 0 comments Download
M Source/core/platform/network/ResourceHandle.h View 3 chunks +5 lines, -8 lines 0 comments Download
M Source/core/platform/network/ResourceHandle.cpp View 6 chunks +10 lines, -26 lines 2 comments Download
M Source/core/platform/network/ResourceHandleInternal.h View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nate Chapin
7 years, 6 months ago (2013-06-03 20:27:36 UTC) #1
abarth-chromium
LGTM +pdr for the potential SVG-in-<img> interaction. https://codereview.chromium.org/16140020/diff/1/Source/core/platform/network/ResourceHandle.cpp File Source/core/platform/network/ResourceHandle.cpp (left): https://codereview.chromium.org/16140020/diff/1/Source/core/platform/network/ResourceHandle.cpp#oldcode228 Source/core/platform/network/ResourceHandle.cpp:228: return false; ...
7 years, 6 months ago (2013-06-03 21:11:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/16140020/1
7 years, 6 months ago (2013-06-03 21:16:24 UTC) #3
pdr.
LGTM. This won't affect SVG images without a followup patch. Thank you for doing this. ...
7 years, 6 months ago (2013-06-03 21:34:42 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8493
7 years, 6 months ago (2013-06-03 22:58:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/16140020/1
7 years, 6 months ago (2013-06-03 23:00:18 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 00:33:21 UTC) #7
Message was sent while issue was closed.
Change committed as 151710

Powered by Google App Engine
This is Rietveld 408576698