Issue 16138003: Write an extension-upgrade browsertest to verify the fix for http://crbug.com/178542.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16138003: Write an extension-upgrade browsertest to verify the fix for http://crbug.com/178542. (Closed)

Created:
7 years, 6 months ago by Jeffrey Yasskin

Modified:
7 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, benwells

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Write an extension-upgrade browsertest to verify the fix for http://crbug.com/178542. Also fixed a bug in ExtensionBrowserTest::InstallOrUpdateExtension where it would silently fail to upgrade a non-idle extension. BUG=178542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203004

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -0 lines)			Patch
M	chrome/browser/extensions/extension_browsertest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_loading_browsertest.cc	View	1 chunk	+158 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Jeffrey Yasskin

I verified this test by rolling back r190543 and watching the test fail.

7 years, 6 months ago (2013-05-29 18:30:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/16138003/1

7 years, 6 months ago (2013-05-29 20:03:38 UTC) #3

Message was sent while issue was closed.

Change committed as 203004