Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 16134003: Support Smi in CompareIDAndBranch (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1663 matching lines...) Expand 10 before | Expand all | Expand 10 after
1674 LOperand* left = UseFixed(instr->left(), r1); 1674 LOperand* left = UseFixed(instr->left(), r1);
1675 LOperand* right = UseFixed(instr->right(), r0); 1675 LOperand* right = UseFixed(instr->right(), r0);
1676 LCmpT* result = new(zone()) LCmpT(left, right); 1676 LCmpT* result = new(zone()) LCmpT(left, right);
1677 return MarkAsCall(DefineFixed(result, r0), instr); 1677 return MarkAsCall(DefineFixed(result, r0), instr);
1678 } 1678 }
1679 1679
1680 1680
1681 LInstruction* LChunkBuilder::DoCompareIDAndBranch( 1681 LInstruction* LChunkBuilder::DoCompareIDAndBranch(
1682 HCompareIDAndBranch* instr) { 1682 HCompareIDAndBranch* instr) {
1683 Representation r = instr->representation(); 1683 Representation r = instr->representation();
1684 if (r.IsInteger32()) { 1684 if (r.IsSmiOrInteger32()) {
1685 ASSERT(instr->left()->representation().IsInteger32()); 1685 ASSERT(instr->left()->representation().IsSmiOrInteger32());
1686 ASSERT(instr->right()->representation().IsInteger32()); 1686 ASSERT(instr->left()->representation().Equals(
1687 instr->right()->representation()));
1687 LOperand* left = UseRegisterOrConstantAtStart(instr->left()); 1688 LOperand* left = UseRegisterOrConstantAtStart(instr->left());
1688 LOperand* right = UseRegisterOrConstantAtStart(instr->right()); 1689 LOperand* right = UseRegisterOrConstantAtStart(instr->right());
1689 return new(zone()) LCmpIDAndBranch(left, right); 1690 return new(zone()) LCmpIDAndBranch(left, right);
1690 } else { 1691 } else {
1691 ASSERT(r.IsDouble()); 1692 ASSERT(r.IsDouble());
1692 ASSERT(instr->left()->representation().IsDouble()); 1693 ASSERT(instr->left()->representation().IsDouble());
1693 ASSERT(instr->right()->representation().IsDouble()); 1694 ASSERT(instr->right()->representation().IsDouble());
1694 LOperand* left = UseRegisterAtStart(instr->left()); 1695 LOperand* left = UseRegisterAtStart(instr->left());
1695 LOperand* right = UseRegisterAtStart(instr->right()); 1696 LOperand* right = UseRegisterAtStart(instr->right());
1696 return new(zone()) LCmpIDAndBranch(left, right); 1697 return new(zone()) LCmpIDAndBranch(left, right);
(...skipping 926 matching lines...) Expand 10 before | Expand all | Expand 10 after
2623 2624
2624 2625
2625 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2626 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2626 LOperand* object = UseRegister(instr->object()); 2627 LOperand* object = UseRegister(instr->object());
2627 LOperand* index = UseRegister(instr->index()); 2628 LOperand* index = UseRegister(instr->index());
2628 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2629 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2629 } 2630 }
2630 2631
2631 2632
2632 } } // namespace v8::internal 2633 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698