Issue 16133011: Run the MessageLoop longer in order to clear out extra DeleteSoon()s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16133011: Run the MessageLoop longer in order to clear out extra DeleteSoon()s. (Closed)

Created:
7 years, 6 months ago by Jeffrey Yasskin

Modified:
7 years, 6 months ago

Reviewers:
vabr (Chromium), commit-bot: I haz the power, Matt Perry

CC:
chromium-reviews, Aaron Boodman, bruening+watch_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, chromium-apps-reviews_chromium.org, Timur Iskhodzhanov

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Run the MessageLoop longer in order to clear out extra DeleteSoon()s. Also revert the leak suppression (r202589) so we'll know if this didn't fix the problem. BUG=244446 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202768

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -12 lines)			Patch
	M	chrome/browser/extensions/test_extension_environment.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/16133011/1

7 years, 6 months ago (2013-05-29 00:31:39 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 6 months ago (2013-05-29 01:17:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/16133011/1

7 years, 6 months ago (2013-05-29 01:30:33 UTC) #5

vabr (Chromium)

7 years, 6 months ago (2013-05-29 07:30:18 UTC) #7

Message was sent while issue was closed.

LGTM, thanks for such a fast investigation and fix!

Vaclav

Expand Messages | Collapse Messages