First pass android support in bisect script.

First pass android support in bisect script.

BUG=245361
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205351

[tonyg, 2013-06-07 21:02:26]

Nice! Just a couple of suggestions, everything else looks good

https://codereview.chromium.org/16132012/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/16132012/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:1348: def GatherReferenceValues(self, good_rev,
bad_rev, cmd, metric, tgt_depot):
The style guide frowns on abbreviations like this. Please spell out
target_depot.

https://codereview.chromium.org/16132012/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:2131: 'platform, "cros", or "android". If you
specify something '
I think there should be a ) after platform

https://codereview.chromium.org/16132012/diff/1/tools/bisect_utils.py
File tools/bisect_utils.py (right):

https://codereview.chromium.org/16132012/diff/1/tools/bisect_utils.py#newcode287
tools/bisect_utils.py:287: 'bisect_android_envsetup_helper.sh')
I wish there was a better approach to doing this in python. But you can at least
eliminate the extract .sh script by following the technique outlined here:
http://stackoverflow.com/questions/3503719/emulating-bash-source-in-python

[shatch, 2013-06-07 21:57:39]

New snapshot uploaded.

https://codereview.chromium.org/16132012/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/16132012/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:1348: def GatherReferenceValues(self, good_rev,
bad_rev, cmd, metric, tgt_depot):
On 2013/06/07 21:02:26, tonyg wrote:
> The style guide frowns on abbreviations like this. Please spell out
> target_depot.

Done.

https://codereview.chromium.org/16132012/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:2131: 'platform, "cros", or "android". If you
specify something '
On 2013/06/07 21:02:26, tonyg wrote:
> I think there should be a ) after platform

Done.

https://codereview.chromium.org/16132012/diff/1/tools/bisect_utils.py
File tools/bisect_utils.py (right):

https://codereview.chromium.org/16132012/diff/1/tools/bisect_utils.py#newcode287
tools/bisect_utils.py:287: 'bisect_android_envsetup_helper.sh')
On 2013/06/07 21:02:26, tonyg wrote:
> I wish there was a better approach to doing this in python. But you can at
least
> eliminate the extract .sh script by following the technique outlined here:
> http://stackoverflow.com/questions/3503719/emulating-bash-source-in-python

Done.

[tonyg, 2013-06-07 22:02:26]

lgtm

https://codereview.chromium.org/16132012/diff/6001/tools/bisect_utils.py
File tools/bisect_utils.py (right):

https://codereview.chromium.org/16132012/diff/6001/tools/bisect_utils.py#newc...
tools/bisect_utils.py:285: os.chdir('src')
Rather than doing this dance of changing the dir and then changing back, you can
just pass cwd=src to Popen().

https://codereview.chromium.org/16132012/diff/6001/tools/bisect_utils.py#newc...
tools/bisect_utils.py:290: bufsize=0)
bufsize isn't necessary, is it?

[shatch, 2013-06-07 22:29:04]

https://codereview.chromium.org/16132012/diff/6001/tools/bisect_utils.py
File tools/bisect_utils.py (right):

https://codereview.chromium.org/16132012/diff/6001/tools/bisect_utils.py#newc...
tools/bisect_utils.py:285: os.chdir('src')
On 2013/06/07 22:02:26, tonyg wrote:
> Rather than doing this dance of changing the dir and then changing back, you
can
> just pass cwd=src to Popen().

Done.

https://codereview.chromium.org/16132012/diff/6001/tools/bisect_utils.py#newc...
tools/bisect_utils.py:290: bufsize=0)
On 2013/06/07 22:02:26, tonyg wrote:
> bufsize isn't necessary, is it?

Done.

[commit-bot: I haz the power, 2013-06-10 16:59:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonhatch@chromium.org/16132012/13001

[commit-bot: I haz the power, 2013-06-10 18:02:49]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-06-10 19:21:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonhatch@chromium.org/16132012/13001

[commit-bot: I haz the power, 2013-06-10 23:49:44]

Change committed as 205351