Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/metrics/variations/eula_accepted_notifier_unittest.cc

Issue 16129004: Consolidate EulaAcceptedNotifier implementations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/eula_accepted_notifier_unittest.cc
===================================================================
--- chrome/browser/metrics/variations/eula_accepted_notifier_unittest.cc (revision 0)
+++ chrome/browser/metrics/variations/eula_accepted_notifier_unittest.cc (revision 0)
@@ -0,0 +1,76 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/variations/eula_accepted_notifier.h"
+
+#include "base/prefs/pref_registry_simple.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/scoped_testing_local_state.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class EulaAcceptedNotifierTest : public testing::Test,
+ public EulaAcceptedNotifier::Observer {
+ public:
+ EulaAcceptedNotifierTest() : eula_accepted_called_(false) {
+ }
+
+ // testing::Test overrides.
+ virtual void SetUp() OVERRIDE {
+ local_state_.registry()->RegisterBooleanPref(prefs::kEulaAccepted, false);
+ notifier_.reset(new EulaAcceptedNotifier(&local_state_));
+ notifier_->Init(this);
+ }
+
+ // EulaAcceptedNotifier::Observer overrides.
+ virtual void OnEulaAccepted() OVERRIDE {
+ EXPECT_FALSE(eula_accepted_called_);
+ eula_accepted_called_ = true;
+ }
+
+ void SetEulaAcceptedPref() {
+ local_state_.SetBoolean(prefs::kEulaAccepted, true);
+ }
+
+ EulaAcceptedNotifier* notifier() {
+ return notifier_.get();
+ }
+
+ bool eula_accepted_called() {
+ return eula_accepted_called_;
+ }
+
+ private:
+ TestingPrefServiceSimple local_state_;
+ scoped_ptr<EulaAcceptedNotifier> notifier_;
+ bool eula_accepted_called_;
+
+ DISALLOW_COPY_AND_ASSIGN(EulaAcceptedNotifierTest);
+};
+
+TEST_F(EulaAcceptedNotifierTest, EulaAlreadyAccepted) {
+ SetEulaAcceptedPref();
+ EXPECT_TRUE(notifier()->IsEulaAccepted());
+ EXPECT_FALSE(eula_accepted_called());
+ // Call it a second time, to ensure the answer doesn't change.
+ EXPECT_TRUE(notifier()->IsEulaAccepted());
+ EXPECT_FALSE(eula_accepted_called());
+}
+
+TEST_F(EulaAcceptedNotifierTest, EulaNotAccepted) {
+ EXPECT_FALSE(notifier()->IsEulaAccepted());
+ EXPECT_FALSE(eula_accepted_called());
+ // Call it a second time, to ensure the answer doesn't change.
+ EXPECT_FALSE(notifier()->IsEulaAccepted());
+ EXPECT_FALSE(eula_accepted_called());
+}
+
+TEST_F(EulaAcceptedNotifierTest, EulaNotInitiallyAccepted) {
+ EXPECT_FALSE(notifier()->IsEulaAccepted());
+ SetEulaAcceptedPref();
+ EXPECT_TRUE(notifier()->IsEulaAccepted());
+ EXPECT_TRUE(eula_accepted_called());
+ // Call it a second time, to ensure the answer doesn't change.
+ EXPECT_TRUE(notifier()->IsEulaAccepted());
+}

Powered by Google App Engine
This is Rietveld 408576698