Issue 16126002: Always deoptimize on undefined if a double value implicitly gets converted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16126002: Always deoptimize on undefined if a double value implicitly gets converted. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Always deoptimize on undefined if a double value implicitly gets converted. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14832

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	src/hydrogen.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
	M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM (drive-by, to hopefully unbreak the bots), although the whole representation logic which is scattered ...

7 years, 6 months ago (2013-05-28 06:28:57 UTC) #2

Toon Verwaest

7 years, 6 months ago (2013-05-28 06:31:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14832 (presubmit successful).