[Android] Generate v14 style resource from values-v17/ not values/.

[Android] Generate v14 style resource from values-v17/ not values/.

If styles.xml has paddingStart and exists in values/, it will cause
crashes on Galaxy Tab&Note because style resources are not overrided by
the generated styles.xml (generate_v14_compatible_resources.py), which is to
avoid crashes on Galaxy Tab&Note (crbug.com/235118). So make
generate_v14_compatible_resource.py use styles.xml under values-v17/ not values/

BUG=243952
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202812

[newt (away), 2013-05-28 21:08:13]

I think this is a good way to do it. Just some nits.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:83: for style_element in
dom.getElementsByTagName('style'):
make this:

    if list(root_node.getElementsByTagName('style')):
      return True

or even

    return bool(root_node.nodeName == 'resources' and
list(root_node.getElementsByTagName('style')))

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:93: sys.exit('error:
style file ' + input_filename + ' should be under ' +
I'd raise an exception here, instead of exiting directly.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:145: output_v14_filename,
align these parameters

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:147: """Convert
layout/style resource to API 14 compatible layout/style resource.
"layout/style" -> "layout"

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:170: """Convert
layout/style resource to API 14 compatible layout/style resource.
"Convert API 17 style resources to API 14 compatible style resources."

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:179: # Write the
generated resource.
I'd pull out lines 179-182 into a separate function, and call it here and in
GenerateV14LayoutResource

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:192: output_v17_filename)
align this argument

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:261: if len(qualifiers) >
0 and qualifiers[-1] == 'v17':
if 'v17' in qualifiers: ...

also, I wouldn't depend on v17 being the final qualifier below. Maybe:

    v17_index = qualifiers.index('v17')
    del qualifiers[v17_index]
    output_v14_dir = os.path.join(options.res_v14_compatibility_dir,
'-'.join([resource_type] + qualifiers))

[Kibeom Kim (inactive), 2013-05-28 23:15:32]

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:83: for style_element in
dom.getElementsByTagName('style'):
On 2013/05/28 21:08:13, newt wrote:
> make this:
> 
>     if list(root_node.getElementsByTagName('style')):
>       return True
> 
> or even
> 
>     return bool(root_node.nodeName == 'resources' and
> list(root_node.getElementsByTagName('style')))

Done.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:93: sys.exit('error:
style file ' + input_filename + ' should be under ' +
On 2013/05/28 21:08:13, newt wrote:
> I'd raise an exception here, instead of exiting directly.

Done.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:145: output_v14_filename,
On 2013/05/28 21:08:13, newt wrote:
> align these parameters

Done.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:147: """Convert
layout/style resource to API 14 compatible layout/style resource.
On 2013/05/28 21:08:13, newt wrote:
> "layout/style" -> "layout"

Done.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:170: """Convert
layout/style resource to API 14 compatible layout/style resource.
On 2013/05/28 21:08:13, newt wrote:
> "Convert API 17 style resources to API 14 compatible style resources."

Done.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:179: # Write the
generated resource.
On 2013/05/28 21:08:13, newt wrote:
> I'd pull out lines 179-182 into a separate function, and call it here and in
> GenerateV14LayoutResource

Done.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:192: output_v17_filename)
On 2013/05/28 21:08:13, newt wrote:
> align this argument

Done.

https://codereview.chromium.org/16125003/diff/4001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:261: if len(qualifiers) >
0 and qualifiers[-1] == 'v17':
I assumed v17 be the final because the versioning is the final qualifier, but
yes, I agree that not relying on that because Android can add another qualifier
group after the versioning.

Done.

On 2013/05/28 21:08:13, newt wrote:
> if 'v17' in qualifiers: ...
> 
> also, I wouldn't depend on v17 being the final qualifier below. Maybe:
> 
>     v17_index = qualifiers.index('v17')
>     del qualifiers[v17_index]
>     output_v14_dir = os.path.join(options.res_v14_compatibility_dir,
> '-'.join([resource_type] + qualifiers))

[newt (away), 2013-05-28 23:21:08]

one nit. otherwise, lgtm

https://codereview.chromium.org/16125003/diff/9001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/16125003/diff/9001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:165:
WriteDomToFile(dom,output_v14_filename)
space after comma

[Kibeom Kim (inactive), 2013-05-28 23:24:04]

https://codereview.chromium.org/16125003/diff/9001/build/android/gyp/generate...
File build/android/gyp/generate_v14_compatible_resources.py (right):

https://codereview.chromium.org/16125003/diff/9001/build/android/gyp/generate...
build/android/gyp/generate_v14_compatible_resources.py:165:
WriteDomToFile(dom,output_v14_filename)
On 2013/05/28 23:21:09, newt wrote:
> space after comma

Done.

[commit-bot: I haz the power, 2013-05-28 23:24:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/16125003/14001

[commit-bot: I haz the power, 2013-05-29 01:26:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/16125003/29001

[commit-bot: I haz the power, 2013-05-29 01:58:27]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-05-29 02:04:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/16125003/29001

[commit-bot: I haz the power, 2013-05-29 08:04:54]

Change committed as 202812