Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 16124013: Fix infinite loading for small images in Files.app. (Closed)

Created:
7 years, 6 months ago by mtomasz
Modified:
7 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix infinite loading for small images in Files.app. When images are small and the same as thumbnails, then the onload callback is not called. This patch fixes this by explicitely clearing the src attribute before any load. TEST=Follow the bug's repro steps on Drive. The image should load fast. BUG=248235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205782

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M chrome/browser/resources/file_manager/js/image_editor/image_util.js View 1 1 chunk +19 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtomasz
@yoshiki: PTAL. Thanks.
7 years, 6 months ago (2013-06-11 06:20:28 UTC) #1
yoshiki
lgtm with nit https://codereview.chromium.org/16124013/diff/1/chrome/browser/resources/file_manager/js/image_editor/image_util.js File chrome/browser/resources/file_manager/js/image_editor/image_util.js (right): https://codereview.chromium.org/16124013/diff/1/chrome/browser/resources/file_manager/js/image_editor/image_util.js#newcode507 chrome/browser/resources/file_manager/js/image_editor/image_util.js:507: var startLoad = function() { nit: ...
7 years, 6 months ago (2013-06-11 06:45:39 UTC) #2
mtomasz
https://codereview.chromium.org/16124013/diff/1/chrome/browser/resources/file_manager/js/image_editor/image_util.js File chrome/browser/resources/file_manager/js/image_editor/image_util.js (right): https://codereview.chromium.org/16124013/diff/1/chrome/browser/resources/file_manager/js/image_editor/image_util.js#newcode507 chrome/browser/resources/file_manager/js/image_editor/image_util.js:507: var startLoad = function() { On 2013/06/11 06:45:39, yoshiki ...
7 years, 6 months ago (2013-06-11 08:14:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16124013/5001
7 years, 6 months ago (2013-06-11 08:14:28 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 09:53:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16124013/5001
7 years, 6 months ago (2013-06-12 03:41:31 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-12 05:14:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16124013/5001
7 years, 6 months ago (2013-06-12 05:20:10 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-12 06:33:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16124013/5001
7 years, 6 months ago (2013-06-12 14:07:56 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 15:11:22 UTC) #11
Message was sent while issue was closed.
Change committed as 205782

Powered by Google App Engine
This is Rietveld 408576698