Issue 16120002: drop unused execinfo.h header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16120002: drop unused execinfo.h header (Closed)

Created:
7 years, 6 months ago by vapier

Modified:
7 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

drop unused execinfo.h header The execinfo.h header only provides prototypes for backtrace funcs. These two files don't use those funcs, so the include is unused. Punt it to make building on non-glibc systems easier. BUG=None TEST=trybot for linux/nacl/cros work Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202666

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	base/debug/debugger_posix.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	base/sys_info_chromeos.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/16120002/1

7 years, 6 months ago (2013-05-28 18:13:41 UTC) #3

Message was sent while issue was closed.

Change committed as 202666

Expand Messages | Collapse Messages