Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1803)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 16110005: Track install speed on devices and fail device status step on low battery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move check install into device status check and fail on low battery. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/device_status_check.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index f9e2883b18900d4a53a7680cc2f43ba061a61de7..6ec9c877b4e1addc9c8b5fea6a882bab2fa168fb 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -162,15 +162,6 @@ def RunChromeDriverTests():
RunCmd(['chrome/test/chromedriver/run_buildbot_steps.py',
'--android-package=%s' % constants.CHROMIUM_TEST_SHELL_PACKAGE])
-
-def CheckInstall():
- """Build bot step to see if adb install works on attached devices. """
- buildbot_report.PrintNamedStep('Check device install')
- # This step checks if apks can be installed on the devices.
- args = ['--apk', 'build/android/CheckInstallApk-debug.apk']
- RunCmd(['build/android/adb_install_apk.py'] + args, halt_on_failure=True)
-
-
def InstallApk(options, test, print_step=False):
"""Install an apk to all phones.
@@ -286,9 +277,6 @@ def MainTestWrapper(options):
target = options.factory_properties.get('target', 'Debug')
RunCmd(['build/android/provision_devices.py', '-t', target])
- # Check to see if devices can install apks.
- CheckInstall()
-
if options.install:
test_obj = INSTRUMENTATION_TESTS[options.install]
InstallApk(options, test_obj, print_step=True)
« no previous file with comments | « no previous file | build/android/device_status_check.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698