Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 16110005: Track install speed on devices and fail device status step on low battery. (Closed)

Created:
7 years, 6 months ago by navabi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

This is a less aggressive patch than the description below. The original was reverted for breaking the Android tests bot (https://codereview.chromium.org/16299003). Removes check install step and moves it into the device status check. This will allow us to examine Android install speeds, which have recently caused timeout problems when installing large APK's. Unlike the original CL, low install speed only causes a warning (i.e. does not fail the step). The step fails if the battery of an online device is less than 5%. BUG=230970, 224004, 242237 --------------------------------------------------- Original CL: Move CheckInstall to device status and fail on low install speed and battery. Removes the recently added CheckInstall step and moves the checking to the device status check step. Recently, devices will install very slowly causing tests to fail with device problems. We have also seen battery issues. The new device status check step will fail if any devices install unreasonably slow (i.e. < 800 KB/s) or have critically low battery level (i.e. < 5%). BUG=230970, 224004, 242237 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204013

Patch Set 1 #

Patch Set 2 : Do not fail for offline devices. #

Patch Set 3 : Move check install into device status check and fail on low battery. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M build/android/buildbot/bb_device_steps.py View 2 chunks +0 lines, -12 lines 0 comments Download
M build/android/device_status_check.py View 1 2 5 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
navabi
7 years, 6 months ago (2013-05-31 23:55:48 UTC) #1
cmp_google
lgtm
7 years, 6 months ago (2013-06-01 00:00:02 UTC) #2
navabi
Thanks Chase. Note: This will also introduce the check install step to the downstream bots, ...
7 years, 6 months ago (2013-06-01 00:04:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16110005/1
7 years, 6 months ago (2013-06-01 00:05:02 UTC) #4
cmp
lgtm
7 years, 6 months ago (2013-06-01 00:12:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16110005/17001
7 years, 6 months ago (2013-06-01 01:05:50 UTC) #6
commit-bot: I haz the power
Change committed as 203587
7 years, 6 months ago (2013-06-01 04:55:01 UTC) #7
navabi
PTAL.
7 years, 6 months ago (2013-06-03 18:55:35 UTC) #8
cmp
lgtm
7 years, 6 months ago (2013-06-03 18:58:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16110005/29001
7 years, 6 months ago (2013-06-03 19:18:24 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, installer_util_unittests, ...
7 years, 6 months ago (2013-06-03 22:58:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16110005/29001
7 years, 6 months ago (2013-06-04 17:47:01 UTC) #12
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 19:19:50 UTC) #13
Message was sent while issue was closed.
Change committed as 204013

Powered by Google App Engine
This is Rietveld 408576698