Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16105005: Cleanup legacy flags and switches (Closed)

Created:
7 years, 7 months ago by Nikita (slow)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Cleanup legacy flags and switches kLoginScreen kLoginScreenSize kAshBootAnimationFunction2 kAshBootAnimationFunction3 kAshDisableBootAnimation2 + related flags See also https://gerrit.chromium.org/gerrit/#/c/56735/ BUG=244224 TEST=compiles, existing browser_tests and autotests work NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202646

Patch Set 1 #

Patch Set 2 : more #

Total comments: 4

Patch Set 3 : nit #

Total comments: 2

Patch Set 4 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -124 lines) Patch
M ash/ash_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/ash_switches.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
M ash/wm/window_animations.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +1 line, -19 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/login_wizard.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/base/animation/tween.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/animation/tween.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nikita (slow)
7 years, 7 months ago (2013-05-27 14:15:04 UTC) #1
Denis Kuznetsov (DE-MUC)
lgtm https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc File chrome/browser/chromeos/policy/device_local_account_browsertest.cc (right): https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc#newcode379 chrome/browser/chromeos/policy/device_local_account_browsertest.cc:379: host->StartSignInScreen(); Why do we need this change in ...
7 years, 6 months ago (2013-05-27 16:46:08 UTC) #2
Nikita (slow)
+Bartosz for browser/chromeos/policy/device_local_account_browsertest.cc https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc File chrome/browser/chromeos/policy/device_local_account_browsertest.cc (right): https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc#newcode379 chrome/browser/chromeos/policy/device_local_account_browsertest.cc:379: host->StartSignInScreen(); On 2013/05/27 16:46:08, Denis Kuznetsov ...
7 years, 6 months ago (2013-05-27 16:49:57 UTC) #3
Nikita (slow)
+sky@ for ash_switches.* I'm sending a separate CL with "per-file ash_switches.*=*"
7 years, 6 months ago (2013-05-27 16:52:05 UTC) #4
Nikita (slow)
On 2013/05/27 16:52:05, Nikita Kostylev wrote: > +sky@ for ash_switches.* > I'm sending a separate ...
7 years, 6 months ago (2013-05-27 16:53:31 UTC) #5
bartfab (slow)
browser/chromeos/policy/device_local_account_browsertest.cc LGTM https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc File chrome/browser/chromeos/policy/device_local_account_browsertest.cc (left): https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc#oldcode25 chrome/browser/chromeos/policy/device_local_account_browsertest.cc:25: #include "chrome/browser/chromeos/login/wizard_controller.h" Nit: No longer used.
7 years, 6 months ago (2013-05-27 17:29:51 UTC) #6
Nikita (slow)
https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc File chrome/browser/chromeos/policy/device_local_account_browsertest.cc (left): https://chromiumcodereview.appspot.com/16105005/diff/2001/chrome/browser/chromeos/policy/device_local_account_browsertest.cc#oldcode25 chrome/browser/chromeos/policy/device_local_account_browsertest.cc:25: #include "chrome/browser/chromeos/login/wizard_controller.h" On 2013/05/27 17:29:52, bartfab wrote: > Nit: ...
7 years, 6 months ago (2013-05-27 17:51:21 UTC) #7
sky
https://chromiumcodereview.appspot.com/16105005/diff/10001/ash/wm/window_animations.cc File ash/wm/window_animations.cc (left): https://chromiumcodereview.appspot.com/16105005/diff/10001/ash/wm/window_animations.cc#oldcode482 ash/wm/window_animations.cc:482: animation_type = ui::Tween::EASE_OUT_2; Can Tween::EASE_OUT_2 and EASE_OUT_3 be nuked ...
7 years, 6 months ago (2013-05-28 15:17:10 UTC) #8
Nikita (slow)
Also removed unused strings. https://chromiumcodereview.appspot.com/16105005/diff/10001/ash/wm/window_animations.cc File ash/wm/window_animations.cc (left): https://chromiumcodereview.appspot.com/16105005/diff/10001/ash/wm/window_animations.cc#oldcode482 ash/wm/window_animations.cc:482: animation_type = ui::Tween::EASE_OUT_2; On 2013/05/28 ...
7 years, 6 months ago (2013-05-28 17:30:49 UTC) #9
sky
LGTM
7 years, 6 months ago (2013-05-28 17:42:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/16105005/14001
7 years, 6 months ago (2013-05-28 20:40:05 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 20:40:20 UTC) #12
Message was sent while issue was closed. 
Change committed as 202646

Powered by Google App Engine
This is Rietveld 408576698