Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 16104003: Disable ScreenCaptureDeviceTest.Capture under Valgrind on Mac (Closed)

Created:
7 years, 7 months ago by earthdok_at_google
Modified:
7 years, 7 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable ScreenCaptureDeviceTest.Capture under Valgrind on Mac BUG=244102 NOTRY=true R=timurrrr@chromium.org ScreenCaptureDeviceTest.Capture causes SEGV_MAPERR under Mac Valgrind. Bug 244102. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202417

Patch Set 1 #

Patch Set 2 : Expanded the comment in exclude file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok_at_google
Please review.
7 years, 7 months ago (2013-05-27 13:19:40 UTC) #1
Timur Iskhodzhanov
lgtm
7 years, 7 months ago (2013-05-27 13:25:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@google.com/16104003/2002
7 years, 7 months ago (2013-05-27 13:25:30 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 13:34:48 UTC) #4
Message was sent while issue was closed.
Change committed as 202417

Powered by Google App Engine
This is Rietveld 408576698