Issue 16103005: Remove some dead code from tools/valgrind/common.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16103005: Remove some dead code from tools/valgrind/common.py (Closed)

Created:
7 years, 7 months ago by Timur Iskhodzhanov

Modified:
7 years, 7 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove some dead code from tools/valgrind/common.py Also, hopefully improve the buffering behaviour, see BUG=163314 NOTRY=true R=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202422

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -50 lines)			Patch
	M	tools/valgrind/common.py	View		3 chunks	+21 lines, -50 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

https://codereview.chromium.org/16103005/diff/1/tools/valgrind/common.py File tools/valgrind/common.py (left): https://codereview.chromium.org/16103005/diff/1/tools/valgrind/common.py#oldcode37 tools/valgrind/common.py:37: def RunSubprocess(proc, timeout=0, detach=False, background=False): FYI: these were never ...

7 years, 7 months ago (2013-05-27 13:51:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/16103005/1

7 years, 7 months ago (2013-05-27 14:15:12 UTC) #3

Message was sent while issue was closed.

Change committed as 202422

Expand Messages | Collapse Messages