Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 16099006: Fix the hole loading optimization. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix the hole loading optimization. - Holes are only ever loaded as double or tagged. - Change to tagged has to deoptimize on undefined (no implicit conversions from double the hole NaN -> tagged undefined). BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14829

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -111 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 4 chunks +17 lines, -24 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 7 chunks +27 lines, -40 lines 0 comments Download
M src/lithium.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 4 chunks +15 lines, -26 lines 0 comments Download
A + test/mjsunit/regress/regress-convert-hole.js View 1 1 chunk +20 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-27 15:16:09 UTC) #1
Toon Verwaest
7 years, 7 months ago (2013-05-27 15:17:10 UTC) #2
Jakob Kummerow
LGTM with a comment that applies to all architectures. Also, how about a regression test ...
7 years, 7 months ago (2013-05-27 16:03:05 UTC) #3
Toon Verwaest
Addressed comments, landing.
7 years, 7 months ago (2013-05-27 17:33:05 UTC) #4
Toon Verwaest
7 years, 7 months ago (2013-05-27 17:33:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14829 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698