Issue 16098005: [Mac][MC] Close the tray window when the user clicks outside it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16098005: [Mac][MC] Close the tray window when the user clicks outside it. (Closed)

Created:
7 years, 6 months ago by Robert Sesek

Modified:
7 years, 6 months ago

Reviewers:
Nico, dewittj

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Mac][MC] Close the tray window when the user clicks outside it. This handles the case for clicking outside Chrome, whereas clicking inside is handled by the -windowDidResignKey: notification. R=dewittj@chromium.org, thakis@chromium.org BUG=243128 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203746

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	ui/message_center/cocoa/tray_controller.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	ui/message_center/cocoa/tray_controller.mm	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

Nico

Also, CL description could mention that this is for the "chromium isn't the foreground app" ...

7 years, 6 months ago (2013-06-03 16:02:08 UTC) #4

Robert Sesek

On 2013/06/03 16:01:49, Nico wrote: > It should probably close when hitting esc too? I'll ...

7 years, 6 months ago (2013-06-03 16:51:25 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/16098005/1

7 years, 6 months ago (2013-06-03 16:51:37 UTC) #7

Message was sent while issue was closed.

Change committed as 203746