Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 16097004: Remove duplicated initialization of stack_parameter_count_ of hydrogen stub descriptor. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 namespace v8 { 43 namespace v8 {
44 namespace internal { 44 namespace internal {
45 45
46 46
47 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor( 47 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor(
48 Isolate* isolate, 48 Isolate* isolate,
49 CodeStubInterfaceDescriptor* descriptor) { 49 CodeStubInterfaceDescriptor* descriptor) {
50 static Register registers[] = { eax, ebx, ecx }; 50 static Register registers[] = { eax, ebx, ecx };
51 descriptor->register_param_count_ = 3; 51 descriptor->register_param_count_ = 3;
52 descriptor->register_params_ = registers; 52 descriptor->register_params_ = registers;
53 descriptor->stack_parameter_count_ = NULL;
54 descriptor->deoptimization_handler_ = 53 descriptor->deoptimization_handler_ =
55 Runtime::FunctionForId(Runtime::kCreateArrayLiteralShallow)->entry; 54 Runtime::FunctionForId(Runtime::kCreateArrayLiteralShallow)->entry;
56 } 55 }
57 56
58 57
59 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor( 58 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor(
60 Isolate* isolate, 59 Isolate* isolate,
61 CodeStubInterfaceDescriptor* descriptor) { 60 CodeStubInterfaceDescriptor* descriptor) {
62 static Register registers[] = { eax, ebx, ecx, edx }; 61 static Register registers[] = { eax, ebx, ecx, edx };
63 descriptor->register_param_count_ = 4; 62 descriptor->register_param_count_ = 4;
64 descriptor->register_params_ = registers; 63 descriptor->register_params_ = registers;
65 descriptor->stack_parameter_count_ = NULL;
66 descriptor->deoptimization_handler_ = 64 descriptor->deoptimization_handler_ =
67 Runtime::FunctionForId(Runtime::kCreateObjectLiteralShallow)->entry; 65 Runtime::FunctionForId(Runtime::kCreateObjectLiteralShallow)->entry;
68 } 66 }
69 67
70 68
71 void KeyedLoadFastElementStub::InitializeInterfaceDescriptor( 69 void KeyedLoadFastElementStub::InitializeInterfaceDescriptor(
72 Isolate* isolate, 70 Isolate* isolate,
73 CodeStubInterfaceDescriptor* descriptor) { 71 CodeStubInterfaceDescriptor* descriptor) {
74 static Register registers[] = { edx, ecx }; 72 static Register registers[] = { edx, ecx };
75 descriptor->register_param_count_ = 2; 73 descriptor->register_param_count_ = 2;
76 descriptor->register_params_ = registers; 74 descriptor->register_params_ = registers;
77 descriptor->stack_parameter_count_ = NULL;
78 descriptor->deoptimization_handler_ = 75 descriptor->deoptimization_handler_ =
79 FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure); 76 FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure);
80 } 77 }
81 78
82 79
83 void LoadFieldStub::InitializeInterfaceDescriptor( 80 void LoadFieldStub::InitializeInterfaceDescriptor(
84 Isolate* isolate, 81 Isolate* isolate,
85 CodeStubInterfaceDescriptor* descriptor) { 82 CodeStubInterfaceDescriptor* descriptor) {
86 static Register registers[] = { edx }; 83 static Register registers[] = { edx };
87 descriptor->register_param_count_ = 1; 84 descriptor->register_param_count_ = 1;
88 descriptor->register_params_ = registers; 85 descriptor->register_params_ = registers;
89 descriptor->stack_parameter_count_ = NULL;
90 descriptor->deoptimization_handler_ = NULL; 86 descriptor->deoptimization_handler_ = NULL;
91 } 87 }
92 88
93 89
94 void KeyedLoadFieldStub::InitializeInterfaceDescriptor( 90 void KeyedLoadFieldStub::InitializeInterfaceDescriptor(
95 Isolate* isolate, 91 Isolate* isolate,
96 CodeStubInterfaceDescriptor* descriptor) { 92 CodeStubInterfaceDescriptor* descriptor) {
97 static Register registers[] = { edx }; 93 static Register registers[] = { edx };
98 descriptor->register_param_count_ = 1; 94 descriptor->register_param_count_ = 1;
99 descriptor->register_params_ = registers; 95 descriptor->register_params_ = registers;
100 descriptor->stack_parameter_count_ = NULL;
101 descriptor->deoptimization_handler_ = NULL; 96 descriptor->deoptimization_handler_ = NULL;
102 } 97 }
103 98
104 99
105 void KeyedStoreFastElementStub::InitializeInterfaceDescriptor( 100 void KeyedStoreFastElementStub::InitializeInterfaceDescriptor(
106 Isolate* isolate, 101 Isolate* isolate,
107 CodeStubInterfaceDescriptor* descriptor) { 102 CodeStubInterfaceDescriptor* descriptor) {
108 static Register registers[] = { edx, ecx, eax }; 103 static Register registers[] = { edx, ecx, eax };
109 descriptor->register_param_count_ = 3; 104 descriptor->register_param_count_ = 3;
110 descriptor->register_params_ = registers; 105 descriptor->register_params_ = registers;
(...skipping 7952 matching lines...) Expand 10 before | Expand all | Expand 10 after
8063 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET); 8058 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET);
8064 } 8059 }
8065 } 8060 }
8066 8061
8067 8062
8068 #undef __ 8063 #undef __
8069 8064
8070 } } // namespace v8::internal 8065 } } // namespace v8::internal
8071 8066
8072 #endif // V8_TARGET_ARCH_IA32 8067 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698