Issue 16096007: add a regression test for requestAutocomplete

Issue 16096007: add a regression test for requestAutocomplete (Closed)

Created:
7 years, 6 months ago by Evan Stade

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Dan Beam

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

add a regression test for requestAutocomplete test is disabled because it will fail until the bug is fixed BUG=244515 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202757

Patch Set 2 : remove unrelated WIP changes #

Total comments: 2

Patch Set 3 : change variable names #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -6 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc	View	1 2	3 chunks	+50 lines, -6 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

https://codereview.chromium.org/16096007/diff/3001/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc File chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc (right): https://codereview.chromium.org/16096007/diff/3001/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc#newcode744 chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:744: AutofillProfile full_profile2(test::GetVerifiedProfile2()); can you use {shipping,billing}_profile so it's more ...

7 years, 6 months ago (2013-05-28 19:17:48 UTC) #2

Evan Stade

7 years, 6 months ago (2013-05-28 19:30:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/16096007/18001

7 years, 6 months ago (2013-05-28 21:20:11 UTC) #6

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5375

7 years, 6 months ago (2013-05-28 21:37:19 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/16096007/18001

7 years, 6 months ago (2013-05-28 23:01:09 UTC) #8

Message was sent while issue was closed.

Change committed as 202757

Expand Messages | Collapse Messages