Issue 16096006: Skip argv[0] when processing command line options in symlink.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16096006: Skip argv[0] when processing command line options in symlink.py (Closed)

Created:
7 years, 6 months ago by Mostyn Bramley-Moore

Modified:
7 years, 6 months ago

Reviewers:
Mark Mentovai, Paweł Hajdan Jr.

CC:
chromium-reviews, rogerj

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Skip argv[0] when processing command line options in symlink.py The problem fixed by this patch is that this script always creates a link to itself in the target location. That behavior was probably not intended and caused problems when running this script several times with the same target folder. Each run of this script would create one expected link and one link to the script itself. Meaning that the need to use --force the second time was needed to overwrite the "self-link" from the first run. Even with --force there were issues if this script was run in parallel since there can be a race condition in overwriting the "self-link". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202661