Issue 16094003: drive: Respect is_recursive parameter in RemoveOperation.

Issue 16094003: drive: Respect is_recursive parameter in RemoveOperation. (Closed)

Created:
7 years, 6 months ago by kinaba

Modified:
7 years, 6 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Respect is_recursive parameter in RemoveOperation. BUG=223855, 244302 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202510

Patch Set 3 : Fix DriveFileSystemExtensionApiTest #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -81 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/remove_operation.h	View		2 chunks	+20 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/remove_operation.cc	View	1	3 chunks	+44 lines, -4 lines	0 comments	Download
A	chrome/browser/chromeos/drive/file_system/remove_operation_unittest.cc	View	1	1 chunk	+115 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View		2 chunks	+0 lines, -64 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/file_browser/filesystem_operations_test/test.js	View	1 2	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm https://codereview.chromium.org/16094003/diff/1/chrome/browser/chromeos/drive/file_system/remove_operation.cc File chrome/browser/chromeos/drive/file_system/remove_operation.cc (right): https://codereview.chromium.org/16094003/diff/1/chrome/browser/chromeos/drive/file_system/remove_operation.cc#newcode89 chrome/browser/chromeos/drive/file_system/remove_operation.cc:89: scoped_ptr<ResourceEntryVector> entries) { nit: How about having DCHECKs ...

7 years, 6 months ago (2013-05-28 02:34:45 UTC) #2

kinaba

Done. Also updated the browser test expectation. https://codereview.chromium.org/16094003/diff/1/chrome/browser/chromeos/drive/file_system/remove_operation.cc File chrome/browser/chromeos/drive/file_system/remove_operation.cc (right): https://codereview.chromium.org/16094003/diff/1/chrome/browser/chromeos/drive/file_system/remove_operation.cc#newcode89 chrome/browser/chromeos/drive/file_system/remove_operation.cc:89: scoped_ptr<ResourceEntryVector> entries) ...

7 years, 6 months ago (2013-05-28 03:31:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/16094003/8001

7 years, 6 months ago (2013-05-28 03:59:53 UTC) #5

Message was sent while issue was closed.

Change committed as 202510

Expand Messages | Collapse Messages