Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 16093041: Fix compilation with gdbjit=on. (Closed)

Created:
7 years, 6 months ago by kennyluck-no-longer-in-use
Modified:
7 years, 6 months ago
Reviewers:
Yang
Base URL:
git://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

Fix compilation with gdbjit=on. r14919 forgot three AssertNoAllocation -> DisallowHeapAllocation replacements. BUG=v8:2719 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15046

Patch Set 1 #

Patch Set 2 : remove GOATS :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/gdb-jit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kennyluck-no-longer-in-use
7 years, 6 months ago (2013-06-10 16:04:45 UTC) #1
Yang
On 2013/06/10 16:04:45, kennyluck wrote: This is great! - I suppose you don't want to ...
7 years, 6 months ago (2013-06-10 16:08:39 UTC) #2
Yang
7 years, 6 months ago (2013-06-10 16:32:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15046 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698