Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 16093026: Provide nanoseconds precision for base::PlatformFileInfo on POSIX (Closed)

Created:
7 years, 6 months ago by apavlov
Modified:
7 years, 6 months ago
Reviewers:
dumi, brettw, tzik
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org, kinuko
Visibility:
Public.

Description

Provide nanoseconds precision for base::PlatformFileInfo on POSIX BUG=244430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205178

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add Time::FromTimeSpec(), fix Mac build #

Patch Set 3 : Guard FromTimeSpec() by the OS_POSIX define #

Patch Set 4 : Android uses yet another structure from file modification timestamps #

Patch Set 5 : st_?time_nsec doe not exist in the bots' NDK, use FromTimeT for Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M base/file_util_posix.cc View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M base/time.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M base/time.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
apavlov
Please take a look. Sorry if the code style is a bit off - it's ...
7 years, 6 months ago (2013-06-04 16:36:11 UTC) #1
apavlov
Folks, I need some guidance on the approach to increasing the file lastModified timestamp resolution ...
7 years, 6 months ago (2013-06-04 21:08:13 UTC) #2
tzik
https://codereview.chromium.org/16093026/diff/1/base/file_util_posix.cc File base/file_util_posix.cc (right): https://codereview.chromium.org/16093026/diff/1/base/file_util_posix.cc#newcode599 base/file_util_posix.cc:599: base::Time::kNanosecondsPerSecond); Can we add Time::FromTimeSpec(const timespec&) and use it ...
7 years, 6 months ago (2013-06-05 04:00:17 UTC) #3
apavlov
https://codereview.chromium.org/16093026/diff/1/base/file_util_posix.cc File base/file_util_posix.cc (right): https://codereview.chromium.org/16093026/diff/1/base/file_util_posix.cc#newcode599 base/file_util_posix.cc:599: base::Time::kNanosecondsPerSecond); On 2013/06/05 04:00:17, tzik wrote: > Can we ...
7 years, 6 months ago (2013-06-05 17:03:41 UTC) #4
tzik
lgtm
7 years, 6 months ago (2013-06-06 06:21:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/16093026/12001
7 years, 6 months ago (2013-06-06 07:13:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=7193
7 years, 6 months ago (2013-06-06 07:25:48 UTC) #7
apavlov
On 2013/06/06 07:25:48, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 6 months ago (2013-06-06 07:29:49 UTC) #8
brettw
lgtm
7 years, 6 months ago (2013-06-07 15:55:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/16093026/12001
7 years, 6 months ago (2013-06-07 15:55:57 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-07 16:18:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/16093026/36001
7 years, 6 months ago (2013-06-10 08:20:10 UTC) #12
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 09:41:36 UTC) #13
Message was sent while issue was closed.
Change committed as 205178

Powered by Google App Engine
This is Rietveld 408576698