Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 16093024: Free PerThreadAssertData when possible to avoid memory leak. (Closed)

Created:
7 years, 6 months ago by Yang
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Free PerThreadAssertData when possible to avoid memory leak. R=svenpanne@chromium.org BUG=246567 Committed: https://code.google.com/p/v8/source/detail?r=14947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M src/assert-scope.h View 5 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 6 months ago (2013-06-04 15:38:01 UTC) #1
Sven Panne
I think we should approach this differently to cleanly separate concerns: Leaving PerThreadAssertData as it ...
7 years, 6 months ago (2013-06-05 08:16:17 UTC) #2
Sven Panne
LGTM as discussed offline
7 years, 6 months ago (2013-06-05 09:40:11 UTC) #3
Yang
7 years, 6 months ago (2013-06-05 09:41:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698