Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 16091011: 2nd try: Split webkit_storage target into webkit_storage_{browser,common,renderer} (Closed)

Created:
7 years, 6 months ago by kinuko
Modified:
7 years, 6 months ago
CC:
chromium-reviews, michaeln, extensions-reviews_chromium.org, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, android-webview-reviews_chromium.org
Visibility:
Public.

Description

2nd try: Split webkit_storage target into webkit_storage_{browser,common,renderer} This does: - Remove all webkit/browser/foo/*.gypi, webkit/common/foo/*.gypi for storage - Add three top-level gyp's in webkit/: storage_{browser,common,renderer}.gyp storage_common and storage_renderer might be able to be subsumed in bigger targets for common|renderer, but believe we can do that later when necessary. Original review: https://codereview.chromium.org/15716007/ BUG=239109 TBR=jamesr@chromium.org,mnaganov@chromium.org,thestig@chromium.org,avi@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205489

Patch Set 1 #

Patch Set 2 : splint_link fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -581 lines) Patch
M android_webview/native/webview_native.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M build/split_link_partition.py View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -1 line 1 comment Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -1 line 1 comment Download
M content/child/fileapi/webfilesystem_callback_adapters.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +7 lines, -3 lines 0 comments Download
A + webkit/base/webkit_base.gyp View 1 chunk +1 line, -1 line 0 comments Download
D webkit/base/webkit_base.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
M webkit/browser/appcache/appcache_response.h View 2 chunks +1 line, -1 line 0 comments Download
D webkit/browser/appcache/webkit_browser_appcache.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D webkit/browser/blob/webkit_browser_blob.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/browser/database/webkit_browser_database.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
D webkit/browser/dom_storage/webkit_browser_dom_storage.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
D webkit/browser/fileapi/webkit_browser_fileapi.gypi View 1 chunk +0 lines, -147 lines 0 comments Download
D webkit/browser/quota/webkit_browser_quota.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D webkit/browser/webkit_browser.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
M webkit/common/appcache/appcache_interfaces.h View 7 chunks +17 lines, -16 lines 0 comments Download
M webkit/common/blob/blob_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/blob/scoped_file.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/blob/shareable_file_reference.h View 1 chunk +1 line, -1 line 0 comments Download
D webkit/common/blob/webkit_common_blob.gypi View 1 chunk +0 lines, -16 lines 0 comments Download
M webkit/common/database/database_connections.h View 3 chunks +3 lines, -3 lines 0 comments Download
D webkit/common/database/webkit_common_database.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_types.h View 3 chunks +3 lines, -3 lines 0 comments Download
D webkit/common/dom_storage/webkit_common_dom_storage.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M webkit/common/fileapi/file_system_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/fileapi/file_system_util.h View 5 chunks +20 lines, -20 lines 0 comments Download
D webkit/common/fileapi/webkit_common_fileapi.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M webkit/common/quota/quota_status_code.h View 2 chunks +2 lines, -2 lines 0 comments Download
D webkit/common/quota/webkit_common_quota.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
M webkit/common/webkit_common.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
D webkit/storage/webkit_storage.gypi View 1 chunk +0 lines, -58 lines 0 comments Download
A webkit/storage_browser.gyp View 1 chunk +262 lines, -0 lines 0 comments Download
A webkit/storage_common.gyp View 1 chunk +48 lines, -0 lines 0 comments Download
A webkit/storage_renderer.gyp View 1 chunk +37 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
The 1st submit try broke win_split bot, will be re-landing with diff from patch set ...
7 years, 6 months ago (2013-06-11 09:35:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/16091011/2001
7 years, 6 months ago (2013-06-11 10:31:48 UTC) #2
commit-bot: I haz the power
Change committed as 205489
7 years, 6 months ago (2013-06-11 10:57:40 UTC) #3
Lei Zhang
chrome/ lgtm with a couple nits. https://codereview.chromium.org/16091011/diff/2001/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/16091011/diff/2001/chrome/chrome_browser_chromeos.gypi#newcode93 chrome/chrome_browser_chromeos.gypi:93: '../webkit/storage_browser.gyp:webkit_storage_browser', nit: storage ...
7 years, 6 months ago (2013-06-11 20:28:59 UTC) #4
kinuko
7 years, 6 months ago (2013-06-12 02:26:17 UTC) #5
Message was sent while issue was closed.
On 2013/06/11 20:28:59, Lei Zhang wrote:
> chrome/ lgtm with a couple nits.
> 
>
https://codereview.chromium.org/16091011/diff/2001/chrome/chrome_browser_chro...
> File chrome/chrome_browser_chromeos.gypi (right):
> 
>
https://codereview.chromium.org/16091011/diff/2001/chrome/chrome_browser_chro...
> chrome/chrome_browser_chromeos.gypi:93:
> '../webkit/storage_browser.gyp:webkit_storage_browser',
> nit: storage before support.
> 
>
https://codereview.chromium.org/16091011/diff/2001/chrome/chrome_browser_ui.gypi
> File chrome/chrome_browser_ui.gypi (right):
> 
>
https://codereview.chromium.org/16091011/diff/2001/chrome/chrome_browser_ui.g...
> chrome/chrome_browser_ui.gypi:2384:
> '../webkit/storage_browser.gyp:webkit_storage_browser',
> ditto.

Thx, I'll make a follow-up patch.

Powered by Google App Engine
This is Rietveld 408576698