Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16091004: LMU creation : nicer user/password error messages (Closed)

Created:
7 years, 7 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 6 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

LMU creation : nicer user/password error messages BUG=229762 R=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202573

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.css View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html View 1 chunk +3 lines, -3 lines 2 comments Download
M chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Denis Kuznetsov (DE-MUC)
7 years, 7 months ago (2013-05-27 18:27:01 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/16091004/diff/1/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html File chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html (right): https://codereview.chromium.org/16091004/diff/1/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html#newcode45 chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html:45: <span id="managed-user-creation-flow-password-error" class="no-error"> Why not div?
7 years, 6 months ago (2013-05-28 11:35:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/16091004/1
7 years, 6 months ago (2013-05-28 13:25:04 UTC) #3
commit-bot: I haz the power
Change committed as 202573
7 years, 6 months ago (2013-05-28 15:26:38 UTC) #4
Nikita (slow)
7 years, 6 months ago (2013-05-28 16:21:48 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/16091004/diff/1/chrome/browser/resources/chro...
File
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html
(right):

https://codereview.chromium.org/16091004/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html:45:
<span id="managed-user-creation-flow-password-error" class="no-error">
On 2013/05/28 11:35:29, Nikita Kostylev wrote:
> Why not div?

Should be div. But let's leave this for general cleanup of our code. New code
should follow these guidelines.

https://sites.google.com/a/google.com/webmaster/code/semantics
http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semant...

Powered by Google App Engine
This is Rietveld 408576698