Issue 16091003: Handle case in LMU creation when there are no managers available

Issue 16091003: Handle case in LMU creation when there are no managers available (Closed)

Created:
7 years, 6 months ago by Denis Kuznetsov (DE-MUC)

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Handle case in LMU creation when there are no managers available BUG=229762 R=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202475

Patch Set 2 : Review #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -13 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_gaia_signin.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_gaia_signin.js	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	1	5 chunks	+26 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://chromiumcodereview.appspot.com/16091003/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): https://chromiumcodereview.appspot.com/16091003/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode1006 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1006: if (managed_users_enabled) { nit: drop {}

7 years, 6 months ago (2013-05-27 17:53:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/16091003/4001

7 years, 6 months ago (2013-05-27 17:55:25 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 6 months ago (2013-05-27 18:09:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/16091003/4001

7 years, 6 months ago (2013-05-27 18:26:53 UTC) #5

Message was sent while issue was closed.

Change committed as 202475

Expand Messages | Collapse Messages