Issue 16090004: Explicitly link AddressSanitizer binaries with -lrt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16090004: Explicitly link AddressSanitizer binaries with -lrt. (Closed)

Created:
7 years, 7 months ago by Alexander Potapenko

Modified:
7 years, 6 months ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews, eugenis

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Explicitly link AddressSanitizer binaries with -lrt. As of Clang r182645 -fsanitize=address implies -lrt, but until that revision is rolled some binaries (e.g. symupload) need an explicit dependency. BUG=234010 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202423

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
		build/common.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/16090004/1

7 years, 7 months ago (2013-05-27 11:55:29 UTC) #2

Nico

7 years, 6 months ago (2013-05-28 20:01:26 UTC) #4

Message was sent while issue was closed.

Hm, this is unfortunate. LGTM, but I wish you had filed a new bug instead of
reusing the old one, as this is a slightly different issue. Please remember to
remmove this again when the time comes.

Expand Messages | Collapse Messages