Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 16089002: Files.app: Fixed the padding of name column header. (Closed)

Created:
7 years, 7 months ago by hirono
Modified:
7 years, 7 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Fixed the padding of name column header. This CL updated CSS and fixed the padding of name column header. BUG=239294 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202412

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed a selector. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hirono
@mtomasz-san, Could you check this tiny CSS CL? Thanks again!
7 years, 7 months ago (2013-05-27 06:27:54 UTC) #1
mtomasz
https://codereview.chromium.org/16089002/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/16089002/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode2227 chrome/browser/resources/file_manager/css/file_manager.css:2227: body[new-ui] #list-container .table-header-cell:nth-child(1) { :first-child won't work here?
7 years, 7 months ago (2013-05-27 06:51:52 UTC) #2
hirono
Fixed. Thank you! https://codereview.chromium.org/16089002/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/16089002/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode2227 chrome/browser/resources/file_manager/css/file_manager.css:2227: body[new-ui] #list-container .table-header-cell:nth-child(1) { On 2013/05/27 ...
7 years, 7 months ago (2013-05-27 07:29:24 UTC) #3
mtomasz
Thanks! lgtm.
7 years, 7 months ago (2013-05-27 07:30:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/16089002/5001
7 years, 7 months ago (2013-05-27 07:30:51 UTC) #5
hirono
On 2013/05/27 07:30:12, mtomasz wrote: > Thanks! lgtm. Thank you for so quick response! I'll ...
7 years, 7 months ago (2013-05-27 07:31:08 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118630
7 years, 7 months ago (2013-05-27 09:53:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/16089002/5001
7 years, 7 months ago (2013-05-27 09:55:58 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 13:22:43 UTC) #9
Message was sent while issue was closed.
Change committed as 202412

Powered by Google App Engine
This is Rietveld 408576698